Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:111006
MIME-Version: 1.0
References: <CAFMT4Nrnn3tvPd9jZCBg3okEuo7YKjqwXUy-vKW4WFLbpqwm4A@mail.gmail.com>
 <CAOsHV+stNWuAAB7JXKEGRf9fNhgk8GGX2RFqyj9Tiaan455nLQ@mail.gmail.com> <CAAKU0ukcCPxRWqewfuWM-BatPFFCOBRV+4COqbdT4XiK4Vf-7g@mail.gmail.com>
In-Reply-To: <CAAKU0ukcCPxRWqewfuWM-BatPFFCOBRV+4COqbdT4XiK4Vf-7g@mail.gmail.com>
Date: Tue, 14 Jul 2020 17:43:15 -0300
Message-ID: <CAOsHV+thCx8ASiCKezpoqicmBsBJ+kfvGvv48=AcpmomJZsRMA@mail.gmail.com>
To: Levi Morrison <levi.morrison@datadoghq.com>
Cc: Levi Morrison <levim@php.net>, internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000f5d71f05aa6cdb1c"
Subject: Re: [PHP-DEV] Changing default assertion mode to throw exceptions
From: marcio.web2@gmail.com (Marcio Almada)

--000000000000f5d71f05aa6cdb1c
Content-Type: text/plain; charset="UTF-8"

Hi!

On Mon, Jul 13, 2020 at 11:52 AM Marcio Almada <marcio.web2@gmail.com>
> wrote:
> > > I'd like to change the default mode of assertion failures to throw.
> > > The current default is to warn. In my opinion this is a bad strategy:
> > > the engine asserted that something that is expected to be true is not,
> > > so executing further is a bad idea. This leaves throwing or bailing
> > > out. I think throwing an exception is better than bailing out, so
> > > that's what I propose.
> >
> > Couldn't agree more, but I always assumed this BC break could be
> > too big before. Did you make any research on the impact already?
> >
> > Otherwise +1
>
> Nikita put together a search of top packagist repositories to look for
> assert:
> https://gist.github.com/nikic/8311ee63c72573d514217456bf2df552
>
> We can't generally know what their ini settings are, though.
>
> In my opinion this change is worth any backwards compatibility break
> as we are choosing the worst setting except for ignoring them
> altogether, and can be changed back to the previous value using an
> existing ini setting; we just need to put a note in the migrating
> guide.
>

I took a look at the top ones + random picks, most are converting
warnings to exceptions at least during tests. Still a +1 from me.

--000000000000f5d71f05aa6cdb1c--