Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:111003
To: Levi Morrison <levim@php.net>
CC: internals <internals@lists.php.net>, Marcio Almada <marcio.web2@gmail.com>
Thread-Topic: [PHP-DEV] Changing default assertion mode to throw exceptions
Thread-Index: AQHWWTwv4QCvmrJUGUWZUbSjZlPTfqkFyiIAgAFlKgCAABDL5w==
Date: Tue, 14 Jul 2020 16:19:26 +0000
Message-ID:
 <BYAPR05MB6535AB98313D0ADCE09F198FDE610@BYAPR05MB6535.namprd05.prod.outlook.com>
References:
 <CAFMT4Nrnn3tvPd9jZCBg3okEuo7YKjqwXUy-vKW4WFLbpqwm4A@mail.gmail.com>
 <CAOsHV+stNWuAAB7JXKEGRf9fNhgk8GGX2RFqyj9Tiaan455nLQ@mail.gmail.com>,<CAAKU0ukcCPxRWqewfuWM-BatPFFCOBRV+4COqbdT4XiK4Vf-7g@mail.gmail.com>
In-Reply-To:
 <CAAKU0ukcCPxRWqewfuWM-BatPFFCOBRV+4COqbdT4XiK4Vf-7g@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-tmn: [flAn2w3f5wnp3bTIHpSuTi3IaT/k5kEp]
x-ms-publictraffictype: Email
x-incomingheadercount: 45
x-eopattributedmessage: 0
x-ms-office365-filtering-correlation-id: aeea1834-77cd-4163-33d1-08d82811ad61
x-ms-traffictypediagnostic: DM6NAM11HT032:
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 8arrypRDNPZpIu7/2KWLRKQhUqz7Ij0Awx2si9lVtpMVFks6Cb8szEJpIur5KBtHPuFqoNzZxIuuwhswpC0nE49W2lGXingR01/VGbLFK5EiYo2G7F51kIGtJd1uQ7BPV0vqOwOCjsrHI2bHebsu3jmCrB+UNRdBo2z0mpOg0/k0pYWPgU40OFxn53UEGBcyfvvkXVtGtxcwvLrEvmJDv3hGe1RuGeA/fUuNqKMpUwy8tzBye0bZRrf/JqjCvi+V
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:0;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR05MB6535.namprd05.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:;DIR:OUT;SFP:1901;
x-ms-exchange-antispam-messagedata:
 2OGCT2Bzfr5hgo9kkU166WAk6EehVnEVCAf2sn+5lZ6GBQc2XIY8cYPFyDVFVhK9Y5nLZ+VVx3fVZZvR5grDFiV8iVybhgihXe6XTz8dZ1a17kOhoPKN3jD8vcuLaAlTz1+izsr5+SHP9yuun/dTgQ==
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT067.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: aeea1834-77cd-4163-33d1-08d82811ad61
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jul 2020 16:19:26.1029
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Internet
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6NAM11HT032
Subject: Re: [PHP-DEV] Changing default assertion mode to throw exceptions
From: theodorejb@outlook.com (Theodore Brown)

On Tue, July 14 2020 at 10:10 AM Levi Morrison wrote:=0A=
=0A=
> On Mon, Jul 13, 2020 at 11:52 AM Marcio Almada <marcio.web2@gmail.com> wr=
ote:=0A=
> > > I'd like to change the default mode of assertion failures to throw.=
=0A=
> > > The current default is to warn. In my opinion this is a bad strategy:=
=0A=
> > > the engine asserted that something that is expected to be true is not=
,=0A=
> > > so executing further is a bad idea. This leaves throwing or bailing=
=0A=
> > > out. I think throwing an exception is better than bailing out, so=0A=
> > > that's what I propose.=0A=
> >=0A=
> > Couldn't agree more, but I always assumed this BC break could be=0A=
> > too big before. Did you make any research on the impact already?=0A=
> >=0A=
> > Otherwise +1=0A=
> =0A=
> Nikita put together a search of top packagist repositories to look for as=
sert:=0A=
> https://gist.github.com/nikic/8311ee63c72573d514217456bf2df552=0A=
> =0A=
> We can't generally know what their ini settings are, though.=0A=
> =0A=
> In my opinion this change is worth any backwards compatibility break=0A=
> as we are choosing the worst setting except for ignoring them=0A=
> altogether, and can be changed back to the previous value using an=0A=
> existing ini setting; we just need to put a note in the migrating=0A=
> guide.=0A=
=0A=
Big +1 on changing the default to throw. The current default of only=0A=
producing a warning is surprising and can result in code continuing=0A=
to execute in a state the developer intended to prevent.=0A=
=0A=
Theodore=