Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:111000
MIME-Version: 1.0
References: <CAFMT4Nrnn3tvPd9jZCBg3okEuo7YKjqwXUy-vKW4WFLbpqwm4A@mail.gmail.com>
 <CAOsHV+stNWuAAB7JXKEGRf9fNhgk8GGX2RFqyj9Tiaan455nLQ@mail.gmail.com>
In-Reply-To: <CAOsHV+stNWuAAB7JXKEGRf9fNhgk8GGX2RFqyj9Tiaan455nLQ@mail.gmail.com>
Reply-To: Levi Morrison <levi.morrison@datadoghq.com>
Date: Tue, 14 Jul 2020 09:10:18 -0600
Message-ID: <CAAKU0ukcCPxRWqewfuWM-BatPFFCOBRV+4COqbdT4XiK4Vf-7g@mail.gmail.com>
To: Marcio Almada <marcio.web2@gmail.com>
Cc: Levi Morrison <levim@php.net>, internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] Changing default assertion mode to throw exceptions
From: internals@lists.php.net ("Levi Morrison via internals")

On Mon, Jul 13, 2020 at 11:52 AM Marcio Almada <marcio.web2@gmail.com> wrote:
> > I'd like to change the default mode of assertion failures to throw.
> > The current default is to warn. In my opinion this is a bad strategy:
> > the engine asserted that something that is expected to be true is not,
> > so executing further is a bad idea. This leaves throwing or bailing
> > out. I think throwing an exception is better than bailing out, so
> > that's what I propose.
>
> Couldn't agree more, but I always assumed this BC break could be
> too big before. Did you make any research on the impact already?
>
> Otherwise +1

Nikita put together a search of top packagist repositories to look for assert:
https://gist.github.com/nikic/8311ee63c72573d514217456bf2df552

We can't generally know what their ini settings are, though.

In my opinion this change is worth any backwards compatibility break
as we are choosing the worst setting except for ignoring them
altogether, and can be changed back to the previous value using an
existing ini setting; we just need to put a note in the migrating
guide.