Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:110995 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 47692 invoked from network); 14 Jul 2020 10:02:24 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 14 Jul 2020 10:02:24 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 2810118050A for ; Tue, 14 Jul 2020 01:54:49 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 X-Spam-Virus: No X-Envelope-From: Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Tue, 14 Jul 2020 01:54:48 -0700 (PDT) Received: by mail-lj1-f171.google.com with SMTP id z24so21505380ljn.8 for ; Tue, 14 Jul 2020 01:54:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1TSw3iBQHlsVGqtTS/xEavk6sydbq8SrAVH2YncJx9c=; b=mXmLkb4UJmkX2WHyDzvWwt2jXHSjBnzYstmRFTPCYu8uJxdheSQMx94ZQJy29fYLrJ jQ/TF2YjzAFjTUDoeko4toibAXopE6EUfdLeBSrG58BHh70NCFS7cFys4GJLJt58H+G7 ag62v44aYA0HDUBMvnXLfO9k1IXDQppkkU4Gi6jvzLok+T/8bcL/BxMaBoZYLFv8JiwK PC+wIvpuCBgzgcyR2BjK+KfktL/KOCw/AcmOnhfideDmgesdNTnPmS2FndfyAKwQ56ph AnhNFeBAikMoU9D+ScKIEoBbkaecDYLb6wyLS0oErCYFF7/rcAVd+L8kRaTlZcceGQcI JTRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1TSw3iBQHlsVGqtTS/xEavk6sydbq8SrAVH2YncJx9c=; b=reG6Ae/2LgmnxHPJVZ0qXFRYuXv8MbWckNzrzvq+pWQd2XkgWAhh4G39zuyp5wARaQ 7y2BJxJLpJjfRNo4TGBJ/fEinYx5JuTFOXDqm2JYTK4fOQuUG9AAU/BCUrVmKCBAHlcO /kpNhBW8Iabdw9dLsOwhv7ejhkeYgWuRKXsJ9vwePNvPRYgM7aBM9VtaRw9fWA3i1whg zmbyY6Nguf/PHNZ12DcfAQjiJsn4HFGPGSTsOFpoU7xRQXbDQ5Sc3qvg3mXFIJr0gann 5CoXH3tRuLYF6HoEEEyDB5pe23fPwsdEKhT0gKR+FXdXc3/iOo2LZlTdQ6LUMAvN21HJ Si4g== X-Gm-Message-State: AOAM53130bRhKVQdIYlTBUDDl922JHebla08weaDwDs8N9cSsSuvlGys Z+nQscCd/vHgpDCMt+q5n/yCTrXVR1A3+Ov5tf4= X-Google-Smtp-Source: ABdhPJyAvnyznyvCxf18d3GGldSzwMho6OdQ5MIjEQRYmkyExwD6i4TB7GPeviw/tjx1aAhYGfit7BERhQxckNCIiIs= X-Received: by 2002:a05:651c:1a7:: with SMTP id c7mr1922498ljn.345.1594716885745; Tue, 14 Jul 2020 01:54:45 -0700 (PDT) MIME-Version: 1.0 References: <5f0cb6d7.1c69fb81.ca1c0.8c75SMTPIN_ADDED_MISSING@mx.google.com> In-Reply-To: <5f0cb6d7.1c69fb81.ca1c0.8c75SMTPIN_ADDED_MISSING@mx.google.com> Date: Tue, 14 Jul 2020 10:54:29 +0200 Message-ID: To: Mark Randall Cc: PHP internals Content-Type: multipart/alternative; boundary="0000000000007e047905aa62f585" Subject: Re: [PHP-DEV] Drop warning about non-public magic methods From: nikita.ppv@gmail.com (Nikita Popov) --0000000000007e047905aa62f585 Content-Type: text/plain; charset="UTF-8" On Mon, Jul 13, 2020 at 9:32 PM Mark Randall wrote: > On 13/07/2020 19:32, Gabriel Caruso wrote: > > This warning does not make much sense as the magic method is executed > > regardless of its visibility. Should it be dropped? > This seems to be the bigger issue... if something is specified as > private, nothing outside its scope has any rights to access it, and that > it does feels unexpected. > > __call should be checked for access IMHO. > I agree. We can drop the warning, but only if make __call() actually respect visibility. Nikita --0000000000007e047905aa62f585--