Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:110990 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 66679 invoked from network); 14 Jul 2020 02:52:41 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 14 Jul 2020 02:52:41 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id A08DC1804C6 for ; Mon, 13 Jul 2020 18:45:01 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 X-Spam-Virus: No X-Envelope-From: Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Mon, 13 Jul 2020 18:45:01 -0700 (PDT) Received: by mail-lj1-f176.google.com with SMTP id q7so20522465ljm.1 for ; Mon, 13 Jul 2020 18:45:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FzU2XyrxH6pxI8YYgiA5TBumpbd6p7kaXyrNzTM26SQ=; b=EOKXBz3rpxTBzd4p0nCl2PG63zcQb0+iZsK4pZBHJzMDA8MGAfeNq7QsJjsrb7Ee9x MNMpQAs5xSdcQtdgPUcQVpumBTWAegwPO/P5ZXlqULjpRsY4rNp4e0xvO8MtrYuFdtJ9 s4tUaNcR48TYDa3aRXxH1pN40Cp0JKyrnNZSsuPiiwos0CRewH7SLjIl4V6QRS3qfzqW FbIFxJUR+2nPNdf7qgmYpBwKoOb4JhELhqZ6Y0PjF280EE5V7ovNpoZSkglxUIsjW/em 72CUbjZfKQoUoYGBp4Fr9etFsFbTvxVmRewJ6Bm64i+vDphXQA/4LQvV6T+TXN/uhxfJ z4qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FzU2XyrxH6pxI8YYgiA5TBumpbd6p7kaXyrNzTM26SQ=; b=lo/BqJoxcmLHQm2Hdr6vkd/563FWqKL+P4YWGPfmaepulRQQic9OgmikhGXekPuy5G TiNq3slP0lO9zBWolJjl0BUlv5ETKwb/XTSV/y6g882LyD/L8vsEXGfvSIzKTtIk3pHk eB/OE/Xa8pyQTDk0U9FT1oczQCStF2fb6ONzkkgq1ITQnvFrfNP50QlijhEutAp/sgYw RMObp/3ewFyoY1KalduYEj/1JD3z17SFKkxNiBL4UpYurUDVxHMg0Z8TwX+IYTa4y7bU g6kwVlGrxox12pOdA9D5+IyYb1NkiQFJTXHv8qc7bm0o16Ub/tuMfhy1z4y/yuKBY4fx gD8Q== X-Gm-Message-State: AOAM532RFVpQ47bEHVIHHj0x+tVm28dSPiTawo0jrXalUSUE0Ma0fi8A iP96pk5WVDVdocYfKtEAJIdXfV2lhVS9TTTcy6547lTFiJA= X-Google-Smtp-Source: ABdhPJwl2bovP1qazbwdFFicQnuIGwWVITj1mIxD1kJheON66oq5NhsSpxd1igYiRz+L27yEDuJka/B1xFOT5Xw6oJI= X-Received: by 2002:a2e:8047:: with SMTP id p7mr1121460ljg.414.1594691097200; Mon, 13 Jul 2020 18:44:57 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: Date: Mon, 13 Jul 2020 22:44:45 -0300 Message-ID: To: Gabriel Caruso Cc: PHP Internals Content-Type: multipart/alternative; boundary="000000000000600a8605aa5cf4b9" Subject: Re: [PHP-DEV] Drop warning about non-public magic methods From: marcio.web2@gmail.com (Marcio Almada) --000000000000600a8605aa5cf4b9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Grabriel, Hello internals, > > During the development of https://wiki.php.net/rfc/magic-methods-signatur= e > I > found something that I'd like to share with you, and possibly propose to > drop it: there's a warning that php-src throws when a magic method is > declared with visibility different than `public`: https://3v4l.org/LKnKB. > > This warning does not make much sense as the magic method is executed > regardless of its visibility. Should it be dropped? > > - Gabriel Caruso > Besides the BC break involved is there any other constraint not to emit a full compile error given that the engine still executes the method call and the visibility, other than public, is therefore invalid code? Ty, M=C3=A1rcio --000000000000600a8605aa5cf4b9--