Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:110981
Message-ID: <EB5FB547-EC82-4E07-9FAC-C2F178EEAF24@joshbruce.dev>
Content-Type: multipart/alternative;
	boundary="Apple-Mail=_4F89B7E4-24FF-4B2B-A7CD-A33156B238A1"
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\))
Date: Mon, 13 Jul 2020 14:07:52 -0500
In-Reply-To: <CAP=4hCKy+Vzr_GgpCTNcEC6YEnRVS4pXPyd+_DLYrUA8Uz5yrA@mail.gmail.com>
Cc: PHP Internals <internals@lists.php.net>
To: Gabriel Caruso <carusogabriel@php.net>
References: <CAP=4hCKy+Vzr_GgpCTNcEC6YEnRVS4pXPyd+_DLYrUA8Uz5yrA@mail.gmail.com>
Subject: Re: [PHP-DEV] Drop warning about non-public magic methods
From: josh@joshbruce.dev (Josh Bruce)

--Apple-Mail=_4F89B7E4-24FF-4B2B-A7CD-A33156B238A1
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

Curious.

I tend to follow PSR-12 (with few exceptions): =
https://www.php-fig.org/psr/psr-12/#44-methods-and-functions =
<https://www.php-fig.org/psr/psr-12/#44-methods-and-functions>

Which requires visibility declaration on all members (methods and =
properties).=20

Would dropping the requirement make the following impossible:

class SomeClass
{
    private function __toString() {}
}

$instance =3D new SomeClass();

$instance->__toString();

It=E2=80=99s one thing if PHP can always reach it, it=E2=80=99s a =
different thing if I, as the developer, can make it so others can=E2=80=99=
t.

Cheers,
Josh

> On Jul 13, 2020, at 1:32 PM, Gabriel Caruso <carusogabriel@php.net> =
wrote:
>=20
> Hello internals,
>=20
> During the development of =
https://wiki.php.net/rfc/magic-methods-signature I
> found something that I'd like to share with you, and possibly propose =
to
> drop it: there's a warning that php-src throws when a magic method is
> declared with visibility different than `public`: =
https://3v4l.org/LKnKB.
>=20
> This warning does not make much sense as the magic method is executed
> regardless of its visibility. Should it be dropped?
>=20
>=20
> - Gabriel Caruso


--Apple-Mail=_4F89B7E4-24FF-4B2B-A7CD-A33156B238A1--