Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:110959
MIME-Version: 1.0
References: <CAJpLVh3VjCV4kR4n2EGnfYx8J6zQ7FafG7Q6kdbQ0HEMxZHMmw@mail.gmail.com>
 <1e39fdcb-16d2-42c3-95cf-507f7b647b50@www.fastmail.com> <CAJpLVh1fyQNPnAPP9SVJ+T4XAGJe95-OYp=w8PsK77zSVr+Qww@mail.gmail.com>
 <3bfb89c5-c8fd-4587-8c1f-8b7bbbaca692@www.fastmail.com> <CAJpLVh0nD87Gu57bPrC51TVyAXhKkEwofkK03SwGQcrP8aEpPQ@mail.gmail.com>
In-Reply-To: <CAJpLVh0nD87Gu57bPrC51TVyAXhKkEwofkK03SwGQcrP8aEpPQ@mail.gmail.com>
Date: Sun, 12 Jul 2020 01:17:33 +0300
Message-ID: <CAGgaK7J_VN36XOtcp7H6LjPEbusRaARFhCxm0Um7vMnH_yiQ1Q@mail.gmail.com>
To: =?UTF-8?Q?Olle_H=C3=A4rstedt?= <olleharstedt@gmail.com>
Cc: Larry Garfield <larry@garfieldtech.com>, php internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000af471305aa31d3e3"
Subject: Re: [PHP-DEV] Possible RFC: UniqueInterface that throws exception at
 refcount > 1
From: maxsem.wiki@gmail.com (Max Semenik)

--000000000000af471305aa31d3e3
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, Jul 12, 2020 at 12:47 AM Olle H=C3=A4rstedt <olleharstedt@gmail.com=
>
wrote:

> You're misunderstanding. :) Yes, it should be shared, but not with the
> same access level as the owner. If a dependent class closes the
> connection it will cause spooky-action-at-a-distance somewhere else in
> the program. Sorry, it's related to refcount as ownership checking and
> not to throwing exception at refcount > 1.


If your class doesn't know whether it created its connection or it was
passed to it, it's badly designed. Not only would that mix concerns (making
DB requests and managing connections), it would also be hard to test and
hard to keep in the programmer's head. Use dependency injection to avoid
that. I'm not convinced by this example. You can't use ownership as a
protection against code doing something stupid. Imagine for a second you've
prevented non-owners from closing your connection. Will that also prevent
non-owners from dropping your database? What about them messing with your
connection object's properties? Language features can only prevent
developers from making accidental mistakes. Bad code is not an accidental
mistake.

--=20
Best regards,
Max Semenik

--000000000000af471305aa31d3e3--