Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:110886
MIME-Version: 1.0
References: <CABdc3WpEmoKTYEsDk+K1Jb=kh7nu8gJ3TkhY5639ueJaWjN9AQ@mail.gmail.com>
 <CAAKU0u=yWxWavQWxx87XTC6hVZ9XPbc0LXrQSpqyu_CwsW5=cQ@mail.gmail.com>
In-Reply-To: <CAAKU0u=yWxWavQWxx87XTC6hVZ9XPbc0LXrQSpqyu_CwsW5=cQ@mail.gmail.com>
Date: Thu, 9 Jul 2020 09:05:24 +0200
Message-ID: <CABdc3WpFiwuQvhhd+ddO=s+CD841ve=QAkfTBo-XaTy3sj1-Yw@mail.gmail.com>
To: Levi Morrison <levi.morrison@datadoghq.com>
Cc: PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000d9845b05a9fcd9aa"
Subject: Re: [PHP-DEV] [RFC][DISCUSSION] debug_backtrace alternative as an
 array of StackFrame objects
From: michal.brzuchalski@gmail.com (=?UTF-8?Q?Micha=C5=82_Marcin_Brzuchalski?=)

--000000000000d9845b05a9fcd9aa
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Levi,

=C5=9Br., 8 lip 2020 o 22:25 Levi Morrison <levi.morrison@datadoghq.com>
napisa=C5=82(a):

> Any opposition for a parameter to limit stack depth? It's something
> I'd like on the old API too.
>

I've updated the RFC with the same arguments as in `debug_backtrace()`
function.
I'm also considering adding a third option for `int $offset =3D 0` in some
known cases
we want by default skip more frames at the beginning when they're known
this would
reduce copying values from skipped frames.

I've also added two additional properties and related methods:

1) property `?string $object_class =3D null` and method `public function
getObjectClass(): ?string`

They expose an object class name which is useful in case we don't wanna
populate frames with the objects.

The additional information could fulfil the
https://bugs.php.net/bug.php?id=3D45351  if frames as objects
would be got accepted as a replacement in `Exception::getTrace()`.

2) property `?\Closure $closure =3D null` and method `public function
getClosure(): ?\Closure`

They expose a closure which is useful in case the frame was produced by
closure call.
This was added to keep the `function` property compatibility with frames
produced by `debug_backtrace()`.

The additional information could fulfil the
https://bugs.php.net/bug.php?id=3D62325 if frames as objects
would be got accepted as a replacement in `Exception::getTrace()`.

Cheers,
--
Micha=C5=82 Marcin Brzuchalski

--000000000000d9845b05a9fcd9aa--