Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:110884
Message-ID: <9BAF6883-A16F-44D2-964E-D4E7297E5296@newclarity.net>
Content-Type: multipart/alternative;
	boundary="Apple-Mail=_8BDC01A0-740E-4FD4-BA2F-C51E8B99B168"
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.14\))
Date: Wed, 8 Jul 2020 16:20:19 -0400
In-Reply-To: <CABdc3WpEmoKTYEsDk+K1Jb=kh7nu8gJ3TkhY5639ueJaWjN9AQ@mail.gmail.com>
Cc: PHP Internals List <internals@lists.php.net>
To: =?utf-8?Q?Micha=C5=82_Marcin_Brzuchalski?= <michal.brzuchalski@gmail.com>
References: <CABdc3WpEmoKTYEsDk+K1Jb=kh7nu8gJ3TkhY5639ueJaWjN9AQ@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC][DISCUSSION] debug_backtrace alternative as an
 array of StackFrame objects
From: mike@newclarity.net (Mike Schinkel)

--Apple-Mail=_8BDC01A0-740E-4FD4-BA2F-C51E8B99B168
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

> On Jul 7, 2020, at 4:46 PM, Micha=C5=82 Marcin Brzuchalski =
<michal.brzuchalski@gmail.com> wrote:
>=20
> Hi internals,
>=20
> following recently added alternative to `token_get_all()` in form of a
> dedicated class `PhpToken`
> I've made a similar proposal for collecting stack traces by =
introducing
> `StackFrame::getTrace()`
> and `StackFrame` which replaces array with keys and values known from
> `debug_backtrace()`.
>=20
> To compete with easier adoption `StackFrame` implements `ArrayAccess`
> giving identical API
> to `debug_backtrace()`.
>=20
> A test script with deep recursion up to 1M frames uses 50% less memory =
than
> `debug_backtrace()`.
>=20
> The RFC is described here https://wiki.php.net/rfc/stack-frame-class
> It includes implementation of PoC and tests.
>=20
> Cheers,
> Micha=C5=82 Marcin Brzuchalski

Yes, excited to see this.

Would adding a method that allows getting a specific stack frame rather =
than the entire trace if you know which on you want take up less memory =
and/or perform better?=20

Something like StackFrame::getFrame(1) which would be functionally =
equivalent to StackFrame::getTrace()[1]?

-Mike



--Apple-Mail=_8BDC01A0-740E-4FD4-BA2F-C51E8B99B168--