Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:110851
MIME-Version: 1.0
References: <0431210B-417F-4576-BF28-E51ECFA8F3EF@joshbruce.dev>
In-Reply-To: <0431210B-417F-4576-BF28-E51ECFA8F3EF@joshbruce.dev>
Date: Mon, 6 Jul 2020 18:54:10 +0200
Message-ID: <CADyq6sK=H__1OypwjsgBmys=QeDsHZeg+MmqSM4=kc1pyhk_Xg@mail.gmail.com>
To: Josh Bruce <josh@joshbruce.dev>
Cc: PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000ec58eb05a9c8b9e9"
Subject: Re: [PHP-DEV] Proposal: A way for classes to define a response to any
 primitive type cast
From: ocramius@gmail.com (Marco Pivetta)

--000000000000ec58eb05a9c8b9e9
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hey Josh,

Similar proposals were raised recently for `__toArray()`: see
https://externals.io/message/108369#108369

I'd endorse avoiding object-to-<scalar> casts via cast operations: they are
a good source of bugs.
My rationale for the discouragement of magic cast methods is explained with
some code examples at
https://github.com/ShittySoft/symfony-live-berlin-2018-doctrine-tutorial/pu=
ll/3#issuecomment-460441229

Greets,

Marco Pivetta

http://twitter.com/Ocramius

http://ocramius.github.com/


On Mon, Jul 6, 2020 at 4:17 PM Josh Bruce <josh@joshbruce.dev> wrote:

> Apologies, first time, still learning and have no historical context -
> timing is what it is.
>
> Proposal type: Concept
>
> Implementer: Unknown, fallback to me after slow learning
>
> Presumed simple implementation as the pattern should already be in place:
>
> Cast of (string) -> __toString() - already implemented
>
> Cast of (bool) -> __toBool()
>
> Cast of (int) -> __toInt()
>
> Cast of (object) -> __toObject()
>
> =E2=80=A6and so on.
>
> Alternative implementation using an interface:
>
> \CastableTo{type}
>
> Extreme implementation:
>
> Make both of the previous available.
>
> Known unknowns:
>
> - Level of interest in something like this in the PHP community outside o=
f
> one upvote on a Stackoverflow question I submitted:
> https://stackoverflow.com/questions/62747837/php-7-tostring-or-other-inte=
rface-for-boolean-values
> <
> https://stackoverflow.com/questions/62747837/php-7-tostring-or-other-inte=
rface-for-boolean-values
> >
> - Whether this conversation or proposal has already occurred.
> - The historical conversation leading to the creation of the __toString()
> method (and stopping there).
> - The current conversation around using magic methods in general and
> specifically when defining a cast response.
> - Enough details on PHP internal development to implement myself (this is
> the first time in 20 years I felt I couldn=E2=80=99t comfortably accompli=
sh what I
> wanted to, thanks for that).
> - What potential collisions could occur if someone (me) wanted to
> implement all possibilities in a single class.
> - Right now __toBool() would be of the most personal benefit - if proposa=
l
> is converted to an RFC, would it be better (faster/smoother) to do one RF=
C
> for all the cast possibilities - or to have an RFC for each cast separate=
ly?
>
> Thank you for the consideration, information, and feedback.
>
> Cheers,
> Josh
>
> ps. Also, apologies again for walking into a new space on a mission, not
> my normal approach.
>
> pps. The primary project inspiring the proposal:
> https://github.com/8fold/php-shoop <https://github.com/8fold/php-shoop>
>
>
>

--000000000000ec58eb05a9c8b9e9--