Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:110845
To: PHP Internals <internals@lists.php.net>
References: <c11e2cfd-aa74-c64e-c8f7-7ddd5cde22ce@gmail.com>
 <C9EDDF3F-1CC1-4252-AF8A-9470B4527754@gmail.com>
 <CALKiJKpReoUVMD0Z5DUmmdTO4VXLX-auP98cfoinO+hgBbQnSA@mail.gmail.com>
 <0915B96B-DFF1-4F24-993B-350D36EB9A74@gmail.com>
Message-ID: <f31d9d33-5126-4b91-db9c-ed5c3f457ca4@gmail.com>
Date: Sun, 5 Jul 2020 17:49:28 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <0915B96B-DFF1-4F24-993B-350D36EB9A74@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-GB
Subject: Re: [PHP-DEV] Improving output of syntax errors
From: rowan.collins@gmail.com (Rowan Tommins)

On 29/06/2020 10:42, Claude Pache wrote:
> Another way to give the programmer the appropriate information, is 
> replacing “quoted string” with “single-quoted string” and 
> “double-quoted string”.
>
> And while I am thinking about it: a case that tends to cause divergent 
> squint is: unexpected '"', which you changed into: unexpected token """


I've pushed up a new version of the patch with three new special cases:

* unexpected token """ -> unexpected double-quote mark
* unexpected quoted string "foo" -> unexpected single-quoted string  
"foo" / unexpected double-quoted string "foo"
* unexpected illegal character "_" -> unexpected character 0xNN (where _ 
is almost certainly a control character, and NN is instead the 
hexadecimal value of the byte)

I've updated the example table with a new column showing those 
additions: https://rwec.co.uk/x/php-parse-errors/comparison.html


If there's no other comments or objections, I would appreciate if 
someone could merge this in so it can be tested in the next alpha :)


Regards,

-- 
Rowan Tommins (né Collins)
[IMSoP]