Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:110835
MIME-Version: 1.0
References: <CANeKSiRe95yUeyUV5S3MU1Bzh7A_Z0OQF_WVNFK16CcbE5wYqw@mail.gmail.com>
 <CAJvSBVO+4dkvMv501zUpGLJCy3VG_=L15+L9UXKy9z+JvVuxGQ@mail.gmail.com>
In-Reply-To: <CAJvSBVO+4dkvMv501zUpGLJCy3VG_=L15+L9UXKy9z+JvVuxGQ@mail.gmail.com>
Date: Fri, 3 Jul 2020 17:07:17 +0300
Message-ID: <CANeKSiSo2mb5hJjM+b8ox5RtaSSiC9m-K6XrGFQSGYWCRoXsWg@mail.gmail.com>
To: Peter Bowyer <phpmailinglists@gmail.com>
Cc: PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000a984d505a98a0b42"
Subject: Re: [PHP-DEV] [RFC] [VOTE] Make constructors and destructors return void
From: benas.molis.iml@gmail.com (Benas IML)

--000000000000a984d505a98a0b42
Content-Type: text/plain; charset="UTF-8"

Hey,

Most of the internals who voted no, as far as I know, did so due to
subjective reasons (i. e. don't want to allow declaring
constructors/destructors as `void`).

I don't think that should affect on what you believe is a change for better
or for worse.

As I mentioned before, it doesn't make much sense to allow `__clone` to be
declared as `void` and make constructors/destructors an exception.

As for the BC break, yes, only people who return something from a
constructor/destructor are in trouble and will get a deprecation warning in
PHP 8.0.

Best regards,
Benas Seliuginas


On Fri, Jul 3, 2020, 3:47 PM Peter Bowyer <phpmailinglists@gmail.com> wrote:

> Hi,
>
> I have voted in favour, but enough people I respect have voted against to
> make me reconsider.
>
> My understanding is the changes will only cause problems to people who
> have returned something from __construct() or __destruct(). As people
> shouldn't have done this, IMO it is a smaller BC issue than the BC break
> that would have been caused if the proposed #[] attribute syntax had been
> chosen.
>
> Peter
>
> On Thu, 2 Jul 2020 at 22:12, Benas IML <benas.molis.iml@gmail.com> wrote:
>
>> Hey internals,
>>
>> I have opened the voting for the RFC, let's hope everything is going
>> to be smooth :). If you have any other questions, let me know!
>>
>> RFC: https://wiki.php.net/rfc/make_ctor_ret_void
>>
>> Best regards,
>> Benas Seliuginas
>>
>> --
>> PHP Internals - PHP Runtime Development Mailing List
>> To unsubscribe, visit: https://www.php.net/unsub.php
>>
>

--000000000000a984d505a98a0b42--