Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:110826
MIME-Version: 1.0
References: <CANeKSiRe95yUeyUV5S3MU1Bzh7A_Z0OQF_WVNFK16CcbE5wYqw@mail.gmail.com>
In-Reply-To: <CANeKSiRe95yUeyUV5S3MU1Bzh7A_Z0OQF_WVNFK16CcbE5wYqw@mail.gmail.com>
Date: Fri, 3 Jul 2020 10:39:43 +0200
Message-ID: <CAOWwgpnb88sZL8GfaFvdkcFL+5rwJntOoRVUxZD1Hu8xiShxRQ@mail.gmail.com>
To: Benas IML <benas.molis.iml@gmail.com>
Cc: PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000020ab2c05a985786b"
Subject: Re: [PHP-DEV] [RFC] [VOTE] Make constructors and destructors return void
From: nicolas.grekas+php@gmail.com (Nicolas Grekas)

--00000000000020ab2c05a985786b
Content-Type: text/plain; charset="UTF-8"

> Hey internals,
>
> I have opened the voting for the RFC, let's hope everything is going
> to be smooth :). If you have any other questions, let me know!
>
> RFC: https://wiki.php.net/rfc/make_ctor_ret_void
>

Hi Benas,

I voted "no" to the RFC because to me adding "void" to constructor and
destructor don't add any value: the semantics of these functions are
totally defined. Annotating the code with "void" is duplicate information.
The best this can do is open another code-style bikeshed war. About
forbidding the functions from returning anything, I don't understand why
this would improve the overall quality of anything. To me, this looks like
gratuitous strictness.

I also don't understand the secondary vote: enforcing "void rules" in 8.1
is a not-allowed BC break. This can only target 9.0 to me, there can be no
discussion about it in a specific RFC. Or did I miss something?

This is just my opinion on the matter of course. Thanks for contributing to
PHP.

Nicolas

--00000000000020ab2c05a985786b--