Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:110825
To: Nikita Popov <nikita.ppv@gmail.com>
CC: Internals <internals@lists.php.net>
Thread-Topic: [PHP-DEV] Re: [RFC] throwable_string_param_max_len: Configurable
 string length in getTraceAsString()
Thread-Index:
 AQHWTJP20y5MXeHBqkCn3pDlPjOL5qjzFy6GgAAE9ICAAAFzAIAAGGjCgADuyICAAP6TVg==
Date: Fri, 3 Jul 2020 02:09:50 +0000
Message-ID:
 <DM6PR07MB66184B01E33102E9E1003FFFF96A0@DM6PR07MB6618.namprd07.prod.outlook.com>
References:
 <DM6PR07MB66184FC97EA43BFA561A4313F9900@DM6PR07MB6618.namprd07.prod.outlook.com>
 <DM6PR07MB6618893AC1E0FEAE7E777143F96C0@DM6PR07MB6618.namprd07.prod.outlook.com>
 <CAF+90c_WuVD9CEAhb_VnVHMN1qtapykLQAyQpMTfqN0uEt_sEQ@mail.gmail.com>
 <CAF+90c9z71xGpn9Z9frfrN_GEpH5K1gmd5E4mMXCO4NwjQHQCw@mail.gmail.com>
 <DM6PR07MB661883EE85793FDD6CB165BDF96C0@DM6PR07MB6618.namprd07.prod.outlook.com>,<CAF+90c_RB6kbHOnOn+xGfYRmRX97RJwj+WzoZ8xv1yyK3Fa4HQ@mail.gmail.com>
In-Reply-To:
 <CAF+90c_RB6kbHOnOn+xGfYRmRX97RJwj+WzoZ8xv1yyK3Fa4HQ@mail.gmail.com>
Accept-Language: en-CA, en-US
Content-Language: en-CA
x-ms-exchange-messagesentrepresentingtype: 1
x-tmn: [l5sxU0l5rtQhqwkW6NsiEnc1aUEYdGes]
x-ms-publictraffictype: Email
x-incomingheadercount: 45
x-eopattributedmessage: 0
x-ms-office365-filtering-correlation-id: 99f44ef4-a448-42b8-a892-08d81ef62aef
x-ms-traffictypediagnostic: SN1NAM02HT254:
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 mq742GAIC1o7ECVfWuIktRjhKx/4GNhzH7rE8rVDQ3ajfc17+KEQZsmeOBqXmgwMunOSHCjmI+lANyZ99QcQQLiE0dP/lxjLfnAY0Ie7v0QExANUTYeMGf2HcV0rTls1cq5a5OfTNjQSIp+EwJJrz7OTqiN2mkyjG4D8pB4apze7DA8zUvhenGd8CMZAyL/qcao672lg1pSSEIoOz4Tu5L4rtDyq9V/xx3fCtv11LhrSAr05lnXqOEMZQOIdnQ6E
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:0;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR07MB6618.namprd07.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:;DIR:OUT;SFP:1901;
x-ms-exchange-antispam-messagedata:
 9Pxdv+SCF4WOIjKra1XqLZyFWbFyuv0sIrJs1vX8iw4aaeTyu60awXlLETC+aOAlZbrLDQjETAUUALEB4b3/OCUL4xUEUeI/0SfITkfjffO5+CmpMHA2GIlpIogrS6zBQ6n0axHksavnNO/MSX1Krw==
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: hotmail.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT036.eop-nam02.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: 99f44ef4-a448-42b8-a892-08d81ef62aef
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jul 2020 02:09:50.3233
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Internet
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1NAM02HT254
Subject: Re: [PHP-DEV] Re: [RFC] throwable_string_param_max_len: Configurable
 string length in getTraceAsString()
From: tysonandre775@hotmail.com (tyson andre)

Hi Nikita,=0A=
=0A=
> Thanks for the update. You'll probably want to remove the corresponding s=
ection under future scope now.=0A=
=0A=
Fixed, forgot to delete that after copying parts of it.=0A=
=0A=
> You may also want to give some more thought about the name of the ini set=
ting name. =0A=
> We already have zend.exception_ignore_args (which is TBH not a great name=
),=0A=
> and now we get throwable_string_param_max_len, which doesn't follow the s=
ame format.=0A=
> Possibly zend.exception_string_param_max_len would fit in better?=0A=
=0A=
I'd agree with zend.exception_ignore_args not being a great name, but maint=
aining the same prefix would make it easier to find/remember correctly.=0A=
I was considering asking about what people thought about zend.exception_str=
ing_param_max_len.=0A=
=0A=
I've updated https://wiki.php.net/rfc/throwable_string_param_max_len=0A=
=0A=
Thanks,=0A=
- Tyson=0A=