Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:110815
MIME-Version: 1.0
References: <DM6PR07MB66184FC97EA43BFA561A4313F9900@DM6PR07MB6618.namprd07.prod.outlook.com>
 <DM6PR07MB6618893AC1E0FEAE7E777143F96C0@DM6PR07MB6618.namprd07.prod.outlook.com>
 <CAF+90c_WuVD9CEAhb_VnVHMN1qtapykLQAyQpMTfqN0uEt_sEQ@mail.gmail.com>
 <CAF+90c9z71xGpn9Z9frfrN_GEpH5K1gmd5E4mMXCO4NwjQHQCw@mail.gmail.com> <DM6PR07MB661883EE85793FDD6CB165BDF96C0@DM6PR07MB6618.namprd07.prod.outlook.com>
In-Reply-To: <DM6PR07MB661883EE85793FDD6CB165BDF96C0@DM6PR07MB6618.namprd07.prod.outlook.com>
Date: Thu, 2 Jul 2020 12:53:05 +0200
Message-ID: <CAF+90c_RB6kbHOnOn+xGfYRmRX97RJwj+WzoZ8xv1yyK3Fa4HQ@mail.gmail.com>
To: tyson andre <tysonandre775@hotmail.com>
Cc: Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000081063205a9733717"
Subject: Re: [PHP-DEV] Re: [RFC] throwable_string_param_max_len: Configurable
 string length in getTraceAsString()
From: nikita.ppv@gmail.com (Nikita Popov)

--00000000000081063205a9733717
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Jul 1, 2020 at 10:46 PM tyson andre <tysonandre775@hotmail.com>
wrote:

> Hi Nikita,
>
> > Why is the lower limit of the ini setting 15 and not 0?
> >
> > I just saw that you mention this possibility as "future scope".
> > I don't think your reasoning there holds up if you take into account
> > that we already introduced zend.exception_ignore_args in PHP 7.4 --
> > and which is enabled by default in production.
> > That removes argument information from exceptions completely.
> > Setting the string parameter length to 0 still provides more informatio=
n
> than that.
>
> I wasn't very familiar with what zend.exception_ignore_args did, so I
> missed that.
> You do have a good point - it may be useful in use cases where string
> contents should be completely hidden
> but it's still useful to log arg types.
>
> I updated https://wiki.php.net/rfc/throwable_string_param_max_len - the
> minimum is now 0,
> and the suggested value in php.ini-production is now 0, and the default
> remains at 15.
>
> ```
> phpdoc-en-git =C2=B1master =C2=BB ag exception_ignore_args
> appendices/migration74/other-changes.xml
> 34:   <literal>zend.exception_ignore_args</literal> is a new INI directiv=
e
> ```
>
> Aside: I think that should be documented in
> https://www.php.net/manual/en/errorfunc.configuration.php or somewhere
> else.
> Right now, the documentation isn't on php.net, just the changelog.


Thanks for the update. You'll probably want to remove the corresponding
section under future scope now.

You may also want to give some more thought about the name of the ini
setting name. We already have zend.exception_ignore_args (which is TBH not
a great name), and now we get throwable_string_param_max_len, which doesn't
follow the same format. Possibly zend.exception_string_param_max_len would
fit in better?

Nikita

--00000000000081063205a9733717--