Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:110809 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 88176 invoked from network); 1 Jul 2020 21:56:53 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 1 Jul 2020 21:56:53 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 5FBE218054D for ; Wed, 1 Jul 2020 13:46:08 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS, SPF_PASS autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS8075 40.80.0.0/12 X-Spam-Virus: No X-Envelope-From: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-oln040092003089.outbound.protection.outlook.com [40.92.3.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Wed, 1 Jul 2020 13:46:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NwqQSiHp/U1KbYA/TXFKs9Nb7rnB4jEgMyWlySv4gPdIvdqcIzPbT4LMYkJd2/yMYdvFPVzfbXeTmO5t1nBqyxvRCR8x/wEvokYaBD4rMMhxWiO1kxmaGzZC/vsALbvqtdJoTkgFqE7C9/hUYTrDSGokLr4N1S310uuC/UH2CpX6Knbl5+qOAY7t8JSp65dVmwrVakOqU0Otaf5YgLHadP8FtyxXZ6P/znuVo7yBBadrXqEMAh0k1QHd/jYx1VVaTOfQ+htQeXqqalf+wS3yh6++eJpgEAMG1CEtsI4q8fWPvOouXaWFnY0AHmXuT5clpJyd9Pll3zqXwCO1pieCrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SOkwApRhs8Czv/2xOFGgVvhBgnhgDezVZx6c1ZcTBLU=; b=dty9oF7DckXfkEtDJNNOFcR7tM6nRtA8SNOBOjyC2jngsSIBUR4sYoYH8F8Bt3voc0XYV7WEaIyta2RyJL9pS5BdCSxsJn34H09ZaVzk9EKzFQZEsq7Hy8m3wDYyHAEd2i3vmdilOQVuhZK0OTPnvORnHFxNjd4M7hA3GA8cQLTfyX171EiqvgYhJvHPICHd42lpsnha1bJ0U4snWMDJYrzonfe7BasWG9iePgf/X+l0vrrmpOqYauJ5dIqU9QzpM8BWznFgatTBx5m27Dah6ao3JTDYChX3TIZV3EpgVAfDQtXSzjxBJ3M94a4sb/kMrLp6OI37XkYQlQOw6MLezg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SOkwApRhs8Czv/2xOFGgVvhBgnhgDezVZx6c1ZcTBLU=; b=P/29jKoKZzy6Q2F82Cjp/kKwDJifTDlM2XHWEjSy0Lz17p2kq4PVXqARrlnyrTcldrW/sXzsMGWTYpGeFUZIsHwkwy8J1e38Y2ESVgG7z601HR9zQMPWjwhWIebFj6SafzF4HD/frwESCoCJ9yg3QxSOZVi08Wi0nX3Hc+KnAVn/QKpA3VIJDxaoSWt0GcXYGzYs6nAz3Zh5A6PBMG6eBR4u2P2csNIN5dQnW4//ISiZhcYLcwwzTi27pVXXIMUDmIzPTFY4Q3a8gmeL2QWQBG8k55nbqwm/Lhxo5MZM+UjWRH8jP4NRL/NOIVNiczTsnsnE5AZYqAjxuWjsHtlZuA== Received: from SN1NAM02FT044.eop-nam02.prod.protection.outlook.com (10.152.72.52) by SN1NAM02HT145.eop-nam02.prod.protection.outlook.com (10.152.73.44) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.20; Wed, 1 Jul 2020 20:46:06 +0000 Received: from DM6PR07MB6618.namprd07.prod.outlook.com (2a01:111:e400:7e44::4f) by SN1NAM02FT044.mail.protection.outlook.com (2a01:111:e400:7e44::173) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.20 via Frontend Transport; Wed, 1 Jul 2020 20:46:06 +0000 Received: from DM6PR07MB6618.namprd07.prod.outlook.com ([fe80::f0c8:f413:c7c1:e934]) by DM6PR07MB6618.namprd07.prod.outlook.com ([fe80::f0c8:f413:c7c1:e934%4]) with mapi id 15.20.3153.023; Wed, 1 Jul 2020 20:46:06 +0000 To: Nikita Popov CC: Internals Thread-Topic: [PHP-DEV] Re: [RFC] throwable_string_param_max_len: Configurable string length in getTraceAsString() Thread-Index: AQHWTJP20y5MXeHBqkCn3pDlPjOL5qjzFy6GgAAE9ICAAAFzAIAAGGjC Date: Wed, 1 Jul 2020 20:46:06 +0000 Message-ID: References: , In-Reply-To: Accept-Language: en-CA, en-US Content-Language: en-CA X-MS-Has-Attach: X-MS-TNEF-Correlator: x-incomingtopheadermarker: OriginalChecksum:026AE93F054DACDAD8233FBA87D18420A9D1D87B92EA248433391510B646BFF8;UpperCasedChecksum:7405CB3D68697279ACEA4C649450927B0981C6BA644AFD7118CC7A08273C17D2;SizeAsReceived:7427;Count:45 x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [5LsLw+axtP/hNlhHNmbDfgeayHUNaRWvkRgHRnmdLlYVklk8b3cbYJfUOVroZm+h] x-ms-publictraffictype: Email x-incomingheadercount: 45 x-eopattributedmessage: 0 x-ms-office365-filtering-correlation-id: 363c2d36-f3cf-4dab-fa5e-08d81dffc6fb x-ms-traffictypediagnostic: SN1NAM02HT145: x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: f6rlscYux7Zts25rqv6sQWUSBAmphQUe6jmc5ntjVbsyksnZVDhsg21xYhO2q7oYALAVRhvUi2/uEbyu50MTknB5YuHNbtec8OLYdo08of2pX9ooDpae/OWVznL1F9rrgY4Dk9LmnGDm2fYb/e0u5VvF45WMZAOpWkamxgIx4pEdG/mUMt55HG+Y6+PnJovACDeSple5R6P6uiNpXgyARCqnjuh5GjG3FVAa369iUy5nJwwl3Un++v5MnDrNta5Y x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:0;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR07MB6618.namprd07.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:;DIR:OUT;SFP:1901; x-ms-exchange-antispam-messagedata: GuNG2rC6DTsopizdKVEBXbdsDo75Si6diSNTBzv9amz/+/u/S4vkmuAvF1aleiollz84Dv+BNQ2Q+Y2aIDghMKqFZJbob5vITrw4ULZ2p2mBd2BFOJgDjCk6n4Wm/ziAYCq7bcmMPhKEWHU88Be+f6ylBBx1t3StBDXvUufwj/Vt7hTX7OBMePdbtcZZ0JBIqll9cytD384F6kgWH/sIcg== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: hotmail.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT044.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 363c2d36-f3cf-4dab-fa5e-08d81dffc6fb X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jul 2020 20:46:06.4813 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1NAM02HT145 Subject: Re: [PHP-DEV] Re: [RFC] throwable_string_param_max_len: Configurable string length in getTraceAsString() From: tysonandre775@hotmail.com (tyson andre) Hi Nikita,=0A= =0A= > Why is the lower limit of the ini setting 15 and not 0?=0A= > =0A= > I just saw that you mention this possibility as "future scope".=0A= > I don't think your reasoning there holds up if you take into account=0A= > that we already introduced zend.exception_ignore_args in PHP 7.4 -- =0A= > and which is enabled by default in production.=0A= > That removes argument information from exceptions completely.=0A= > Setting the string parameter length to 0 still provides more information = than that.=0A= =0A= I wasn't very familiar with what zend.exception_ignore_args did, so I misse= d that.=0A= You do have a good point - it may be useful in use cases where string conte= nts should be completely hidden=0A= but it's still useful to log arg types.=0A= =0A= I updated https://wiki.php.net/rfc/throwable_string_param_max_len - the min= imum is now 0,=0A= and the suggested value in php.ini-production is now 0, and the default rem= ains at 15.=0A= =0A= ```=0A= phpdoc-en-git =B1master =BB ag exception_ignore_args=0A= appendices/migration74/other-changes.xml=0A= 34: zend.exception_ignore_args is a new INI directive= =0A= ```=0A= =0A= Aside: I think that should be documented in https://www.php.net/manual/en/e= rrorfunc.configuration.php or somewhere else.=0A= Right now, the documentation isn't on php.net, just the changelog.=0A= =0A= Thanks,=0A= - Tyson=