Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:110767
Message-ID: <0915B96B-DFF1-4F24-993B-350D36EB9A74@gmail.com>
Content-Type: multipart/alternative;
	boundary="Apple-Mail=_B70BDCD1-E63A-46AF-A1B1-1054ECCEB4B2"
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\))
Date: Mon, 29 Jun 2020 11:42:07 +0200
In-Reply-To: <CALKiJKpReoUVMD0Z5DUmmdTO4VXLX-auP98cfoinO+hgBbQnSA@mail.gmail.com>
Cc: PHP Internals <internals@lists.php.net>
To: Rowan Tommins <rowan.collins@gmail.com>
References: <c11e2cfd-aa74-c64e-c8f7-7ddd5cde22ce@gmail.com>
 <C9EDDF3F-1CC1-4252-AF8A-9470B4527754@gmail.com>
 <CALKiJKpReoUVMD0Z5DUmmdTO4VXLX-auP98cfoinO+hgBbQnSA@mail.gmail.com>
Subject: Re: [PHP-DEV] Improving output of syntax errors
From: claude.pache@gmail.com (Claude Pache)

--Apple-Mail=_B70BDCD1-E63A-46AF-A1B1-1054ECCEB4B2
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8



> Le 29 juin 2020 =C3=A0 10:29, Rowan Tommins <rowan.collins@gmail.com> =
a =C3=A9crit :
>=20
>=20
> I did actually have strings matching the quote marks used in an =
earlier
> version of the patch, but dropped it partly to simplify the =
implementation
> - because it sometimes truncates strings, it can't just use the real
> quotes, but has to strip and re-add them.
>=20
> The consistency should aid anyone trying to parse the error message, =
since
> the pattern /unexpected ([^"]+) "(.*?)"/ will always give you a token =
name
> (even if just 'token') and its content.
>=20
> I can re-visit that part if you feel strongly, though.

At this point, I don=E2=80=99t feel strongly, because currently, when I =
see
=E2=80=9Cunexpected '''' (T_CONSTANT_ENCAPSED_STRING)=E2=80=9D,
my automatism is not looking for a string with specific quote style =
(which is not evident by looking at four consecutive quotes), but for a =
missing or misplaced punctuation mark, because, by experience, it is =
most of the time the root cause of an error message containing that =
specific token name.

Another way to give the programmer the appropriate information, is =
replacing =E2=80=9Cquoted string=E2=80=9D with =E2=80=9Csingle-quoted =
string=E2=80=9D and =E2=80=9Cdouble-quoted string=E2=80=9D.

And while I am thinking about it: a case that tends to cause divergent =
squint is: unexpected '"', which you changed into: unexpected token """. =
In that specific case, it would be nice if it the common name of the =
offending token was spelt out, something like: unexpected double =
quotation mark.

=E2=80=94Claude=

--Apple-Mail=_B70BDCD1-E63A-46AF-A1B1-1054ECCEB4B2--