Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:110764
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\))
In-Reply-To: <c11e2cfd-aa74-c64e-c8f7-7ddd5cde22ce@gmail.com>
Date: Mon, 29 Jun 2020 08:27:33 +0200
Cc: PHP Internals <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <C9EDDF3F-1CC1-4252-AF8A-9470B4527754@gmail.com>
References: <c11e2cfd-aa74-c64e-c8f7-7ddd5cde22ce@gmail.com>
To: Rowan Tommins <rowan.collins@gmail.com>
Subject: Re: [PHP-DEV] Improving output of syntax errors
From: claude.pache@gmail.com (Claude Pache)



> As a special-case, quoted strings show the string's *content* in =
double quotes, e.g. 'unexpected quoted string "foo" ...' rather than =
'unexpected quoted string ""foo"" ...' or 'unexpected quoted string =
"'foo'" ...'.

For me, in this case, you have dropped the wrong pair of quotes. That =
is, I prefer to see the quotes used in the source text (=E2=80=9Cunexpecte=
d string 'foo' ...=E2=80=9D or =E2=80=9Cunexpected string "foo" ...=E2=80=9D=
), over the quotes that make error messages consistent with other error =
messages. This is because I like to have hints that help me to visually =
identify the offending string in the source text when it is of length 0 =
or 1, but on other hand I don=E2=80=99t care about consistency across =
error messages.=20

=E2=80=94Claude