Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:110763
MIME-Version: 1.0
In-Reply-To: <e311ca83-69ca-93f5-f19a-c478edc06c61@gmail.com>
References: <c11e2cfd-aa74-c64e-c8f7-7ddd5cde22ce@gmail.com> <e311ca83-69ca-93f5-f19a-c478edc06c61@gmail.com>
Date: Mon, 29 Jun 2020 00:08:57 +0200
Message-ID: <CAOwTYAt00qSHOg=6Xb3q4NTN=K65XM1xGeD+UUuw33zmCSUikg@mail.gmail.com>
To: Stanislav Malyshev <smalyshev@gmail.com>
Cc: Rowan Tommins <rowan.collins@gmail.com>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000053411505a92c30e3"
Subject: Re: [PHP-DEV] Improving output of syntax errors
From: krakjoe@gmail.com (Joe Watkins)

--00000000000053411505a92c30e3
Content-Type: text/plain; charset="UTF-8"

Nicely done.

No need for an RFC.

Thanks.

On Sunday, 28 June 2020, Stanislav Malyshev <smalyshev@gmail.com> wrote:

> Hi!
>
> > For more examples, see:
> > https://rwec.co.uk/x/php-parse-errors/comparison.html
> >
> > The patch can be reviewed at: https://github.com/php/php-src/pull/5722
>
> I think this is great, thanks for implementing it!
>
> > I am happy to post a small RFC if people think this requires a vote.
> >
> > Any other feedback is welcome.
>
> I personally don't think it requires a vote, as error messages are an
> implementation detail and nobody should ever rely on it. Let's wait for
> a bit though if somebody argues that it needs an RFC, but otherwise I
> think we can merge it.
>
> > (As an aside, the other commonly requested change was to include column
> > numbers; this appears to be feasible, but definitely more complex, and
> > with potential performance trade-offs. I hope to re-visit this later.)
>
> Column numbers would be awesome too.
>
> --
> Stas Malyshev
> smalyshev@gmail.com
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: https://www.php.net/unsub.php
>
>

--00000000000053411505a92c30e3--