Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:110762
To: Rowan Tommins <rowan.collins@gmail.com>,
 PHP Internals <internals@lists.php.net>
References: <c11e2cfd-aa74-c64e-c8f7-7ddd5cde22ce@gmail.com>
Message-ID: <e311ca83-69ca-93f5-f19a-c478edc06c61@gmail.com>
Date: Sun, 28 Jun 2020 14:03:44 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0)
 Gecko/20100101 Thunderbird/68.9.0
MIME-Version: 1.0
In-Reply-To: <c11e2cfd-aa74-c64e-c8f7-7ddd5cde22ce@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Improving output of syntax errors
From: smalyshev@gmail.com (Stanislav Malyshev)

Hi!

> For more examples, see:
> https://rwec.co.uk/x/php-parse-errors/comparison.html
> 
> The patch can be reviewed at: https://github.com/php/php-src/pull/5722

I think this is great, thanks for implementing it!

> I am happy to post a small RFC if people think this requires a vote.
> 
> Any other feedback is welcome.

I personally don't think it requires a vote, as error messages are an
implementation detail and nobody should ever rely on it. Let's wait for
a bit though if somebody argues that it needs an RFC, but otherwise I
think we can merge it.

> (As an aside, the other commonly requested change was to include column
> numbers; this appears to be feasible, but definitely more complex, and
> with potential performance trade-offs. I hope to re-visit this later.)

Column numbers would be awesome too.

-- 
Stas Malyshev
smalyshev@gmail.com