Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:110754
To: "G. P. B." <george.banyard@gmail.com>
Cc: PHP internals <internals@lists.php.net>
References: <CAFPFaMLAt_p52-ZWL5VAJENgQ-KznYHPidLaC3HaU3n338thTw@mail.gmail.com>
 <php.internals-110738@news.php.net>
 <5ef7505d.1c69fb81.a3d3d.67e7SMTPIN_ADDED_MISSING@mx.google.com>
 <CAFPFaMLEeRkY1UtO1qaS5F5tVn_BP8qYQ5LDcb9TtSNiYdYMeg@mail.gmail.com>
Message-ID: <2375cffc-5526-79e8-4fb0-6fbcbc4646a7@gmail.com>
Date: Sat, 27 Jun 2020 16:03:27 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0)
 Gecko/20100101 Thunderbird/68.9.0
MIME-Version: 1.0
In-Reply-To: <CAFPFaMLEeRkY1UtO1qaS5F5tVn_BP8qYQ5LDcb9TtSNiYdYMeg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV][RFC][VOTE] Rename T_PAAMAYIM_NEKUDOTAYIM to
 T_DOUBLE_COLON
From: smalyshev@gmail.com (Stanislav Malyshev)

Hi!

> Better error messages are obviously better than just replacing the name of
> the token, however this argument is saying that because this isn't perfect
> let's do nothing.

I don't think this is the argument. I think the argument is rather than
half-fix the problem wrong way, let's fully fix it the right way.

> I find it highly frustrating, and borderline offensive, that we are being
> asked to go from a simple, non BC breaking, easy to enact change, to a
> semi-major overhaul of how error messages should look like. I personally

I am not sure why is this "offensive" to you. Is there something in
overhauling error messages that goes against your principles or
religious beliefs? Sometimes overhauling is exactly what is the right
way to go, and not showing internal parser tokens seems to be quite
reasonable idea. If this idea is somehow "offensive" to you, I feel
sorry for you but it's not a reason to abandon this idea. It is also
quite a common things - many proposals in PHP have been rejected because
the community thought it's not the right way to approach things, I
myself have had some proposals rejected because of this. There's no
reason to feel offended by that.

> My perception is that most of the community finds it baffling why anyone
> would be against this change.

My perception is that most of the community couldn't care less for how
the tokens are named, and really shouldn't. It's an internal thing and
should stay this way. If they made to care, that's our fault and we
should fix it.

-- 
Stas Malyshev
smalyshev@gmail.com