Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:110716
Message-ID: <13A2D674-778B-4B5F-955F-1E5F79C2E87B@benramsey.com>
Content-Type: multipart/signed;
	boundary="Apple-Mail=_FB1A6125-3520-4D2F-8037-6289E041EC21";
	protocol="application/pgp-signature";
	micalg=pgp-sha256
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.14\))
Date: Wed, 24 Jun 2020 10:25:03 -0500
In-Reply-To: <DM6PR07MB6618474C462FCA39CCBB8451F9950@DM6PR07MB6618.namprd07.prod.outlook.com>
Cc: "internals@lists.php.net" <internals@lists.php.net>
To: tyson andre <tysonandre775@hotmail.com>
References: <DM6PR07MB6618474C462FCA39CCBB8451F9950@DM6PR07MB6618.namprd07.prod.outlook.com>
Subject: Re: [PHP-DEV] Permitting trailing commas in closure use()
 declarations
From: ben@benramsey.com (Ben Ramsey)

--Apple-Mail=_FB1A6125-3520-4D2F-8037-6289E041EC21
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

> On Jun 24, 2020, at 10:22, tyson andre <tysonandre775@hotmail.com> =
wrote:
>=20
> Hi internals,
>=20
> https://wiki.php.net/rfc/trailing_comma_in_parameter_list mentioned
>=20
>> https://wiki.php.net/rfc/list-syntax-trailing-commas Trailing Commas =
In List Syntax was a previous proposal to support optional trailing =
commas in all list-like structures.
>>=20
>> Nothing has substantially changed since those RFCs in technical =
terms, but I think the aforementioned style > for breaking up large =
parameter lists has become more accepted in the meantime, and features =
like Constructor Property Promotion are going to increase its use =
further.
>=20
> So I'm wondering if anyone's interested in revisiting this:
>=20
> - It'd be easy to forget that function parameters support trailing =
commas, but not closure uses, especially if you're new to the language.
> - Supporting trailing commas in multi-line declarations would make =
version control history easier
> - if you had a closure for which `fn` wouldn't work (a list of values =
*and references* to use, or a list of statements),
>  it'd be convenient to split it up across multiple lines
>=20
> e.g.
>=20
> ```
>        $incrementing_id =3D 0;
>        return \array_map(static function (array $map) use (
>            $function,
>            $some_data_structure,
>            $some_flag,
>            &$incrementing_id,
>        ): ReturnType {
> ```


+1 for consistency with allowing trailing commas in all places like =
this.

Cheers,
Ben


--Apple-Mail=_FB1A6125-3520-4D2F-8037-6289E041EC21
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iHUEAREIAB0WIQToXQMR3fpbrPOmEOewLZeYnIwHGwUCXvNwTwAKCRCwLZeYnIwH
G8HfAP9EgAZkEJ6T2xHok+WvR/hX1eSv5zZHZOpcYfxXHDz/PwD+NUObFFS7Bqds
IskToKZzWf8sokttbjtMOE4bIstFq4c=
=TRbC
-----END PGP SIGNATURE-----

--Apple-Mail=_FB1A6125-3520-4D2F-8037-6289E041EC21--