Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:110693 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 65444 invoked from network); 21 Jun 2020 16:25:49 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 21 Jun 2020 16:25:49 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id B34C51804C3 for ; Sun, 21 Jun 2020 08:12:32 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS15169 209.85.128.0/17 X-Spam-Virus: No X-Envelope-From: Received: from mail-vs1-f49.google.com (mail-vs1-f49.google.com [209.85.217.49]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Sun, 21 Jun 2020 08:12:32 -0700 (PDT) Received: by mail-vs1-f49.google.com with SMTP id r5so5695480vso.11 for ; Sun, 21 Jun 2020 08:12:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=basereality-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=l3Ae8G5MtohankDJPXAd6wVTwF8i6V6D2cOySkka8ps=; b=N2RUw200vKWbz7S9HX4/VvlMQbrMII+9auDpyX/t4WvVsh/sSCj/ypePRh5jGgivm3 D+Jedt+lA2efwm/bKn6EfGMdvZ9e4upou1HI86cvlwmcOzEsq41TyjN1BoGiwLSHW9/T ZzCJ5btslsFeEuTYzsAQ0+1XLOkZlsxvcUaGkzESp/8UFLSJ/D3mBS1qpopoEAJq54fk x5lzfMdEncexyVOvJcQOeSpOTOaC6B7weRVsfNNlOOlbHrqPq2e1Xiu+wKIYTyNjWkNn vl5lm56Eqq/WSfjXiY7Hfw+TUcemKLMcJ16n1FKmfdZVEWx2SsDzbGZ148tfaz/7Ieso pfqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=l3Ae8G5MtohankDJPXAd6wVTwF8i6V6D2cOySkka8ps=; b=kJoBzuCQEYUZVjatCRMF0Bg4uYR8bF6PiNoeUftirI0ypovTCtE+oU+z5KFzr2kwBF 2MqgD1Z3F3FhIdD4g3EILGicp+k73G9D01AVrIxaA7JKHrDF44qKFbEslQ308EiAM0m4 A8y+EFFmmRMFpAw35ZGMdTBXmIKA/GaZMAVv/HFtUODYDMySleJGTanK4CsVw8B2pr1C 5MxUgdoaj/DPLvCcreZmRO1Szf2hp30tNPwK1xz+OaIDlX7AIhbNvDQBJP0mCiEgLnXc DaS+TgKcG7jsyu38nJtDlzEiPDOtpS+uiwjDwhv5+AjGru683f9A/r/9JK1ZfHoeJAry HkOg== X-Gm-Message-State: AOAM533P6g1yTcTVgRe+29XXIgC5Lz9Xtzlv/PID+5gzA9X2men/xmN3 0TZRk5i2h99G+RpdKyfbj4e/USx4D45K9lb/6RS5Tg== X-Google-Smtp-Source: ABdhPJyVHlosQu0Di79gs2Mo5cTgjclVG2P/c1w824vKq/fYuTX4abLNoNKIPWVeoPChUO/fZVXC3T+Fvv5D3wii/Z8= X-Received: by 2002:a67:3117:: with SMTP id x23mr12716564vsx.46.1592752349691; Sun, 21 Jun 2020 08:12:29 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: Date: Sun, 21 Jun 2020 16:12:18 +0100 Message-ID: To: Peter Bowyer Cc: PHP internals Content-Type: text/plain; charset="UTF-8" Subject: Re: [PHP-DEV] SQLite3, PDO/SQLite and driver specific methods From: Danack@basereality.com (Dan Ackroyd) On Sat, 20 Jun 2020 at 15:22, Peter Bowyer wrote: > > Digging into the PHP source code is a fun challenge. It really isn't. Collecting and publishing information on how to work on PHP core, is one thing that takes a lot of time, that we should make easier for people to contribute to. > I've got stuck with adding `PDO::connect('sqlite:...')` [3]. Can someone take a look and give me advice? Thomas Weinert has a repo that implements features in core. Each branch shows how to do a separate thing. Adding a class is on this branch: https://github.com/ThomasWeinert/php-extension-sample/tree/class_method Though you would need the ZEND_ACC_STATIC flag for the method entry also. Also, probably useful: http://www.phpinternalsbook.com/ Might be easier for people to help you if you open a pull request, as that has more visibility, easier places to comment. cheers Dan Ack