Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:110685
MIME-Version: 1.0
References: <CAP=4hCLHKv1iqj462iQaYJdE3AcNy8mDVMW10EBFegqTXSf0bw@mail.gmail.com>
 <CA+kxMuR78DTY==UstVNZ57WyPvmVJiNPu0U65HVvgomEKD3ujw@mail.gmail.com>
In-Reply-To: <CA+kxMuR78DTY==UstVNZ57WyPvmVJiNPu0U65HVvgomEKD3ujw@mail.gmail.com>
Date: Fri, 19 Jun 2020 15:42:29 +0200
Message-ID: <CADyq6s+PKXFvgN4wmZmB5-DPp4spLSy6QnkhyOK44YH_AFXX9w@mail.gmail.com>
To: Dan Ackroyd <Danack@basereality.com>
Cc: Gabriel Caruso <carusogabriel34@gmail.com>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000002096f605a87011f0"
Subject: Re: [PHP-DEV] Make `always true` SPL methods return void
From: ocramius@gmail.com (Marco Pivetta)

--0000000000002096f605a87011f0
Content-Type: text/plain; charset="UTF-8"

Hey Dan, Gabriel,

On Wed, Jun 17, 2020 at 12:17 PM Dan Ackroyd <Danack@basereality.com> wrote:

> On Wed, 17 Jun 2020 at 03:00, Gabriel Caruso <carusogabriel34@gmail.com>
> wrote:
> >
> >  so changing it to `void` and
> > just invoke these methods sounds reasonable to me.
>
> What's the benefit of doing the change?
>
> There will almost certainly be some code somewhere that would be
> broken by changing it, so it needs some benefit for doing it.
>
> I strongly suspect just updating the documentation to be correct, and
> then leaving the code behaving as it has been for the past decade or
> so, would be a better strategy.
>

Perhaps this is a good chance to fix the quirks around the `false` type, as
well as introducing the `true` type (and using it for these specific
functions)?

See https://3v4l.org/ZnWmc/rfc#output
See https://3v4l.org/MqsvC/rfc#output

Marco Pivetta

http://twitter.com/Ocramius

http://ocramius.github.com/

--0000000000002096f605a87011f0--