Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:110678
MIME-Version: 1.0
References: <CAP=4hCLHKv1iqj462iQaYJdE3AcNy8mDVMW10EBFegqTXSf0bw@mail.gmail.com>
 <CA+kxMuR78DTY==UstVNZ57WyPvmVJiNPu0U65HVvgomEKD3ujw@mail.gmail.com>
In-Reply-To: <CA+kxMuR78DTY==UstVNZ57WyPvmVJiNPu0U65HVvgomEKD3ujw@mail.gmail.com>
Date: Thu, 18 Jun 2020 23:17:06 -0400
Message-ID: <CAES=RMtFoRXiUdkHP1VR802tOhUvkDz28qGGFAmy9SScaidxhw@mail.gmail.com>
To: Dan Ackroyd <Danack@basereality.com>
Cc: Gabriel Caruso <carusogabriel34@gmail.com>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000d5a32305a867537f"
Subject: Re: [PHP-DEV] Make `always true` SPL methods return void
From: jr@rushlow.dev (Jesse Rushlow)

--000000000000d5a32305a867537f
Content-Type: text/plain; charset="UTF-8"

* Disclaimer - I have not thoroughly reviewed the bug report or PR
mentioned.

From a PHP developers perspective, if I was calling a method that returned
true. I would automatically assume that the method is capable of returning
the inverse of that as well. I see Dan's point of "let sleeping dogs lie"
per say and just adjust the docs. But I'm leaning more towards if a method
can't return false & true, then it should return something else or void.

Thanks
Jesse Rushlow

On Wed, Jun 17, 2020 at 6:18 AM Dan Ackroyd <Danack@basereality.com> wrote:

> On Wed, 17 Jun 2020 at 03:00, Gabriel Caruso <carusogabriel34@gmail.com>
> wrote:
> >
> >  so changing it to `void` and
> > just invoke these methods sounds reasonable to me.
>
> What's the benefit of doing the change?
>
> There will almost certainly be some code somewhere that would be
> broken by changing it, so it needs some benefit for doing it.
>
> I strongly suspect just updating the documentation to be correct, and
> then leaving the code behaving as it has been for the past decade or
> so, would be a better strategy.
>
> cheers
> Dan
> Ack
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: https://www.php.net/unsub.php
>
>

--000000000000d5a32305a867537f--