Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:110634
To: Ilija Tovilo <tovilo.ilija@gmail.com>
References: <CAPyj-LB7jSiv+7DheaYpEcZXbjeJ9OMsRUTMOofnWbH4LyOQhA@mail.gmail.com>
 <CAPyj-LCV640AZpc=GPb2A+FxqWcSgnzzAH0VVLedCuM0RawmVQ@mail.gmail.com>
 <37f1f8fb-0e1b-cc39-f4b6-6c943a731d49@telia.com>
 <CAPyj-LAreEydWbK1JcBduQuDtu8r4Bv5a-Oma7mFkr3H2Y3y2A@mail.gmail.com>
Cc: PHP internals <internals@lists.php.net>
Message-ID: <250b7671-2919-9385-c149-931212397e4b@telia.com>
Date: Wed, 17 Jun 2020 16:48:01 +0200
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.9.0
MIME-Version: 1.0
In-Reply-To: <CAPyj-LAreEydWbK1JcBduQuDtu8r4Bv5a-Oma7mFkr3H2Y3y2A@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-GB
Subject: Re: [RFC][DISCUSSION] Match expression v2
From: bjorn.x.larsson@telia.com (=?UTF-8?Q?Bj=c3=b6rn_Larsson?=)

Den 2020-06-16 kl. 18:17, skrev Ilija Tovilo:
> Hi Björn
>
>>>> I'd like to announce the match expression v2 RFC:
>>>> https://wiki.php.net/rfc/match_expression_v2
>> I do like this RFC and have one comment. Would it be suitable
>> to have : as a separator instead of =>?
> `=>` is usually used in combination expressions (arrays, yield, arrow
> functions). `:` is mostly used for switch cases and the alternative
> control structure syntax [1]. `=>` also visually separates the
> condition and expression better IMO. This has been suggested once
> before but that's not enough for me to change it at this point.

Well one could argue that when working with legacy code containing
switch statements where one gradually migrates to match, it might be
easier to have the same separator, i.e. ":".

Is the proposed => separator inspired by Rust or Scala? Checked what
other languages used and  for switch it's ":" of course. So one might
argue that to align with match statements in other languages "=>" is
a good choice, but OTOH if ones sees match as an enhanced switch,
having ":" as a separator is another alternative.

Anyway, I think it would be good if the RFC is updated with what other
languages uses, since that is a good motivation for why using "=>" as a
separator. What bothered me a little with that selection is the usage
of the "=>" symbol for other things in PHP. Hint, I was a fan of the
"==>" for arrow functions ;-)

r//Björn L