Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:110630
MIME-Version: 1.0
References: <CANeKSiR18yf7modMbr5ZB5XSe6a3MKwurdZeq9L2g3X=OpUYSA@mail.gmail.com>
 <CANeKSiTikOJGcsGYgqYKJ9RCHpyyhyD66D7N2YRFGRHcqL7v0Q@mail.gmail.com>
 <8ADA2EC7-EE07-4429-8F84-1E5ADC7660E6@cschneid.com> <CAF+90c8Pqc03ahWcQ+Wz2NAPh2xLd+LoB9haGAvHSR+k++9MhQ@mail.gmail.com>
 <CAH5C8xXm1mc+w=4P2duh-HzMroYdV-1edZyioZfWY00+ee+oHg@mail.gmail.com>
 <CANeKSiQxhBMY1bD0t4VUotG7Wh01p==xAhEm9Vfb3c6JvLFseQ@mail.gmail.com> <36A0AE2B-3052-4C55-AAC8-37E76C7E0561@cschneid.com>
In-Reply-To: <36A0AE2B-3052-4C55-AAC8-37E76C7E0561@cschneid.com>
Date: Wed, 17 Jun 2020 16:53:20 +0300
Message-ID: <CANeKSiSjt+8Leruz6GwkhhWaEtcSQ8nSZV6mvg3KcnACAZxgeA@mail.gmail.com>
To: Christian Schneider <cschneid@cschneid.com>
Cc: PHP Internals List <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] [RFC] [DISCUSSION] Allow void return type for constructors/destructors
From: benas.molis.iml@gmail.com (Benas IML)

Hey Christian,

Wrong wording, sorry! :)

> But I definitely wouldn't want a deprecation warning for constructors without explicit ': void' as I see no reason to force people to use it.

This RFC proposes 2 things:

1) If a non-void value is returned from a constructor/destructor, a
deprecation warning is thrown. Meanwhile, in PHP 9.0 a fatal error is
thrown instead.
2) It will be allowed to declare constructors/destructors explicitly
as `: void` (previously this was illegal).

Best regards,
Benas

On Wed, 17 Jun 2020 at 16:36, Christian Schneider <cschneid@cschneid.com> wrote:
>
> Am 17.06.2020 um 13:59 schrieb Benas IML <benas.molis.iml@gmail.com>:
> > We should allow newer codebases to enforce `void` rules on
> > constructors/destructors by allowing to explicitly declare return type as `void`.
>
> I don't see a big benefit in this explicit return type void as newer codebases hopefully will try to get rid of deprecation warnings and thus fixing it but if you think this is helpful then I'll shut up :-)
>
> > Meanwhile, we should throw a deprecation warning, if the constructor/destructor is
> > returning a non-void value and doesn't have an explicit `: void` declaration.
>
> I'm not sure I understand the second part "and doesn't have an explicit `: void` declaration".
> If there is a ' : void' declaration then returning any value will be an error.
> As far as I can see this is already the case:
>         php -r 'class A { function __construct() : void { return 42; } }'
> with PHP 7.4 gives
>         PHP Fatal error: A void function must not return a value in Command line code on line 1
>
> But I definitely wouldn't want a deprecation warning for constructors without explicit ': void' as I see no reason to force people to use it.
>
> > Then, presumably in PHP 9, in addition to explicit `: void`, also enforce `void` rules implicitly
> > altogether.
>
> Yes, that's how I would do it.
>
> - Chris
>