Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:110627 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 13378 invoked from network); 17 Jun 2020 11:32:15 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 17 Jun 2020 11:32:15 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id DA1ED180211 for ; Wed, 17 Jun 2020 03:17:54 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS15169 209.85.128.0/17 X-Spam-Virus: No X-Envelope-From: Received: from mail-vk1-f169.google.com (mail-vk1-f169.google.com [209.85.221.169]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Wed, 17 Jun 2020 03:17:54 -0700 (PDT) Received: by mail-vk1-f169.google.com with SMTP id i1so423971vkp.8 for ; Wed, 17 Jun 2020 03:17:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=basereality-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KsruSkk0F9gFOtBCo5oOI5KSXUM125idsNGN7v1iq4g=; b=IcnED0LyZrNoh6JIpZpgXqxjhkpfIoT/AnL49+lYq9G61FWljY+2rtI7SpWlDrQeLp RYllpMP26e6B023VPjdumz4GgvEoRBWy7JEC+3sX8nvkh+RWRHdZzFG8yrRva6+vZqB/ RuILFEoENkQxlkzSd81pGu58e2TFctW9JRvaPytGQFHJ7H5tjK6kmEWgk1um7QzLrNt9 0GqrgjtmKfYafVpeTGmEaKkSDKDlS93E4XV32bHjSy9+HZUkweLNyZIuvQ7WvxpUssrM l6AeqGcUmNTNzMquf9/vvc4h7cRJHchzqZYChVOEqE73NAw98O+XvMDmeX21J8DWCuzl H//g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KsruSkk0F9gFOtBCo5oOI5KSXUM125idsNGN7v1iq4g=; b=ndspq3EXGPZixX25frKroAp9lVRNXtngnJpBdiOoWcHr8oL8lYTJX6K+LRVF2JVyeu dnPn+NcMta6Ymoj7Aw4UqpZ+jR8q5EMQX37Kn0wmzG/rRnv/NS0XLJvHyao+aI8drw6U 4/ptRUf3aS3LqPxtKm2o2ziHkXxgXanRcpFH2fqs4S/xhVQqNRFAMP4Bi8LWhkT+lIML uIuk0Wf3pQ1orfCnVvEsgerdjKY+qpGA72KH9gLt0LRfxK9iz0oI2CeHvdeaIet23V18 mxmH6gshDOp6ls8woSx77iM6/gWeb42HsXAuFeHmW4Om2myj+pMERmRWYeQJxpaC/o67 v37Q== X-Gm-Message-State: AOAM531vstcK1tEOlM1/OGcQg77IKsbNoWb1ie52ag5bh5hhwP7I8UWw a6xf0QCsjMt4q44gHIp/V+HY3oKlTRhMdvYBYkHwlQ== X-Google-Smtp-Source: ABdhPJyT3GYGCHt0IH1bY1X3EI/muiu61qV1piSbgioEghy0bM5zVhIvexFp56XxqsIq9DO1Ok7O9q6mkWLavrxYHMc= X-Received: by 2002:a1f:6282:: with SMTP id w124mr4887313vkb.97.1592389073724; Wed, 17 Jun 2020 03:17:53 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: Date: Wed, 17 Jun 2020 11:17:42 +0100 Message-ID: To: Gabriel Caruso Cc: PHP Internals Content-Type: text/plain; charset="UTF-8" Subject: Re: [PHP-DEV] Make `always true` SPL methods return void From: Danack@basereality.com (Dan Ackroyd) On Wed, 17 Jun 2020 at 03:00, Gabriel Caruso wrote: > > so changing it to `void` and > just invoke these methods sounds reasonable to me. What's the benefit of doing the change? There will almost certainly be some code somewhere that would be broken by changing it, so it needs some benefit for doing it. I strongly suspect just updating the documentation to be correct, and then leaving the code behaving as it has been for the past decade or so, would be a better strategy. cheers Dan Ack