Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:110619
MIME-Version: 1.0
References: <CANeKSiR18yf7modMbr5ZB5XSe6a3MKwurdZeq9L2g3X=OpUYSA@mail.gmail.com>
 <CANeKSiTikOJGcsGYgqYKJ9RCHpyyhyD66D7N2YRFGRHcqL7v0Q@mail.gmail.com>
 <8ADA2EC7-EE07-4429-8F84-1E5ADC7660E6@cschneid.com> <CAF+90c8Pqc03ahWcQ+Wz2NAPh2xLd+LoB9haGAvHSR+k++9MhQ@mail.gmail.com>
In-Reply-To: <CAF+90c8Pqc03ahWcQ+Wz2NAPh2xLd+LoB9haGAvHSR+k++9MhQ@mail.gmail.com>
Date: Wed, 17 Jun 2020 10:31:34 +0200
Message-ID: <CAH5C8xXm1mc+w=4P2duh-HzMroYdV-1edZyioZfWY00+ee+oHg@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: Christian Schneider <cschneid@cschneid.com>, Benas IML <benas.molis.iml@gmail.com>, 
	PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000076cc5205a8437d1c"
Subject: Re: [PHP-DEV] [RFC] [DISCUSSION] Allow void return type for constructors/destructors
From: kocsismate90@gmail.com (=?UTF-8?B?TcOhdMOpIEtvY3Npcw==?=)

--00000000000076cc5205a8437d1c
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

>
> This PR should also address all of M=C3=A1t=C3=A9's concerns since it mak=
es
> constructors and destructors always return `void` (even when no explicit
> `void` return type is specified).


To be clear, my main concern was that declaring a void return type
shouldn't be
allowed, unless it's actually enforced. Now, it's all fine because you
stated your
intentions :)

However, I am also fine if the void return value is only enforced when the
void return
type is declared. Additionally, we could emit a deprecation notice/warning
when
there is no return type declaration, but a value is returned. I think this
would be
a nice way to immediately give people the possibility to disallow a return
value,
while being respectful for older code bases.

Regards,
M=C3=A1t=C3=A9

--00000000000076cc5205a8437d1c--