Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:110617
MIME-Version: 1.0
References: <CANeKSiR18yf7modMbr5ZB5XSe6a3MKwurdZeq9L2g3X=OpUYSA@mail.gmail.com>
 <CANeKSiTikOJGcsGYgqYKJ9RCHpyyhyD66D7N2YRFGRHcqL7v0Q@mail.gmail.com> <8ADA2EC7-EE07-4429-8F84-1E5ADC7660E6@cschneid.com>
In-Reply-To: <8ADA2EC7-EE07-4429-8F84-1E5ADC7660E6@cschneid.com>
Date: Wed, 17 Jun 2020 10:07:03 +0200
Message-ID: <CAF+90c8Pqc03ahWcQ+Wz2NAPh2xLd+LoB9haGAvHSR+k++9MhQ@mail.gmail.com>
To: Christian Schneider <cschneid@cschneid.com>
Cc: Benas IML <benas.molis.iml@gmail.com>, PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000268f3a05a84326d1"
Subject: Re: [PHP-DEV] [RFC] [DISCUSSION] Allow void return type for constructors/destructors
From: nikita.ppv@gmail.com (Nikita Popov)

--000000000000268f3a05a84326d1
Content-Type: text/plain; charset="UTF-8"

On Wed, Jun 17, 2020 at 9:18 AM Christian Schneider <cschneid@cschneid.com>
wrote:

> Am 16.06.2020 um 21:30 schrieb Benas IML <benas.molis.iml@gmail.com>:
> > I put the original RFC on hold and created a new PR [0] for implicitly
> > enforcing `void` rules on both constructors and destructors. Note, that
> > this results in a BC break since it is no longer legal to return non-void
> > value from constructors/destructors. In other words, it is now illegal to
> > return something from ctor.
>
> This is a huge BC break as up to now returning something in a constructor
> was silently ignored.
> Therefore I'd strongly advise to go through a deprecation phase
> (E_DEPRECATED or E_WARNING) before making it a fatal error so old software
> can be fixed first.
>

I analyzed the top 2k composer packages, and found 95 places that would be
affected by making __construct implicitly void:
https://gist.github.com/nikic/e0d7c9c810e15b843ffd7d6779a2e49a

Common cases seem to be "return parent::__construct()", "return $this" and
"return false".

There's not a lot of them, but I do tend to agree that starting out with a
warning would be better.

Regards,
Nikita

--000000000000268f3a05a84326d1--