Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:110615 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 49278 invoked from network); 17 Jun 2020 03:14:52 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 17 Jun 2020 03:14:52 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id E499C1804A8 for ; Tue, 16 Jun 2020 19:00:25 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS15169 209.85.128.0/17 X-Spam-Virus: No X-Envelope-From: Received: from mail-io1-f54.google.com (mail-io1-f54.google.com [209.85.166.54]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Tue, 16 Jun 2020 19:00:25 -0700 (PDT) Received: by mail-io1-f54.google.com with SMTP id w18so927638iom.5 for ; Tue, 16 Jun 2020 19:00:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=9oWDvV90fAYWCUUeZNuee1YcwcX11K7CqhmTrYKXvl0=; b=dXnNzEBUzMNC+Z3oU1rsa7h2/WrN0vVHQhENjGPaf2vwpRbqGO1iMDqk1Hb364pvDN 2MSwM5nhKGbGHbY+cvF+59kFHH8lNIaNeFV8k1gn+9ga1WBpUKnH+tKeGl1pWIhTwW4P WSkfrs72R4E3voBBfWrpZZg4gZCe7yvNx4iY3zo17rj6a+sgP4UZbAw+FIw0iFqeT9KH GKAB5xYIlYi+7m4evkmPa6/RY3If/ukxvM34MTmlYVp3ZkxdHV0ng+j8s347B9wPbnuH JBN7loS3nx4yf9PI7yKEK7octLKhxTc8jTmid6jFwGmzoUPU3zl2gKRROBTIYu5UiMVk HLOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=9oWDvV90fAYWCUUeZNuee1YcwcX11K7CqhmTrYKXvl0=; b=lJqbqR/qVq+q+OQDgk2T7Cbp/qFtgJ2lDhtSwIt+ubYSivRczSduSZPciGgspvixgV FMiYCQNB689ZBCvtUgcIHn3Rv7lXocJbdp5dNH6/5b1hdeXDlLAy7dGkt5RvhfT61kGd mByNW19MN/OEFqI6Yf+cS4EF1iiuov5ZentC0vmpHiLDaNOeHwLfoTVFqRJ7aAIj7Zuf l6Xq3oUk+zwHao6luDj4BuWR1Azbf9i6Dsu949OhKzU6LEsGInHI6h9jUI5JV7a15GxE dkDVCZihIaWwCTRfKu3Gn4G7omf1p00bkNFWyXxdlysz5ySCkv5ZKTeXK7iAJq8d8HyH XYLA== X-Gm-Message-State: AOAM531ai65JfvO84fFah3ghyMrGuuIlWAH79Maq/vTM6sVQSnN9BEBY Ph/sCEAkBY/M3rbz9NRzBQP7nrTpF+0HMOVn95hjWjAOopY= X-Google-Smtp-Source: ABdhPJyOI8IeDH4ytnqzIPqWrTO8gdbunV0uz9R+eu/PJ5W5GfjLv6SKySYAQqj3DRqnPgi4S7v8SHHNu/tq4zR3tto= X-Received: by 2002:a05:6638:1405:: with SMTP id k5mr27856411jad.108.1592359224815; Tue, 16 Jun 2020 19:00:24 -0700 (PDT) MIME-Version: 1.0 Date: Wed, 17 Jun 2020 04:00:09 +0200 Message-ID: To: PHP Internals Content-Type: multipart/alternative; boundary="000000000000f3371905a83e054f" Subject: [PHP-DEV] Make `always true` SPL methods return void From: carusogabriel34@gmail.com (Gabriel Caruso) --000000000000f3371905a83e054f Content-Type: text/plain; charset="UTF-8" Hello, internals, Inspired by the bug report #75958 (http://bugs.php.net/75958), I'd like to change the return type of some SPL methods that are always returning `true` and only `true`. These "always `true`" returns make no sense, as you can't wrap it in an `if`/`else` to catch something that happened, so changing it to `void` and just invoke these methods sounds reasonable to me. You can find the PR, with some discussion already, at https://github.com/php/php-src/pull/5314. Can I proceed with these changes, or should I create an RFC for that? -- Gabriel Caruso --000000000000f3371905a83e054f--