Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:110613
MIME-Version: 1.0
References: <CANeKSiTAYFOUvA+V+Ytb=N91OPMv_iuJ1m6iFq2kPE80Qp0QJw@mail.gmail.com>
In-Reply-To: <CANeKSiTAYFOUvA+V+Ytb=N91OPMv_iuJ1m6iFq2kPE80Qp0QJw@mail.gmail.com>
Date: Wed, 17 Jun 2020 03:44:21 +0300
Message-ID: <CAAwdEzApkVMnDoxYqyQH=UbUok-MGe6gwJqcddKj0Y5YAxtptg@mail.gmail.com>
To: Benas IML <benas.molis.iml@gmail.com>
Cc: PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000b4b4e305a83cf6e3"
Subject: Re: [PHP-DEV] [RFC] [DISCUSSION] Make constructors and destructors
 return void
From: drealecs@gmail.com (=?UTF-8?Q?Alexandru_P=C4=83tr=C4=83nescu?=)

--000000000000b4b4e305a83cf6e3
Content-Type: text/plain; charset="UTF-8"

Hi Benas,

This looks good to me.

Can you do a research on top 1k-2k most used composer packages and verify
how small the BC break it is?

Also, a suggestion on how to fix the BC issue if it exists could be
mentioned I guess.

Thank you,
Aled

On Wed, Jun 17, 2020, 02:11 Benas IML <benas.molis.iml@gmail.com> wrote:

> Hey internals,
>
> This is a completely refined, follow-up RFC to my original RFC. Based on
> the
> feedback I have received, this PR implements full validation and implicitly
> enforces `void` rules on constructors/destructors while also allowing to
> declare an **optional** explicit `void` return type. Note, that there is a
> small but justifiable BC break (as stated by the RFC).
>
> RFC: https://wiki.php.net/rfc/make_ctor_ret_void
>
> Best regards,
> Benas Seliuginas
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: https://www.php.net/unsub.php
>
>

--000000000000b4b4e305a83cf6e3--