Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:1106 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 42558 invoked from network); 29 Apr 2003 14:59:16 -0000 Received: from unknown (HELO secure.thebrainroom.com) (213.239.42.171) by pb1.pair.com with SMTP; 29 Apr 2003 14:59:16 -0000 Received: from zaneeb.brainnet.i (brain.dial.nildram.co.uk [195.149.29.154]) by secure.thebrainroom.com (8.9.3/8.9.3) with ESMTP id PAA21919; Tue, 29 Apr 2003 15:59:14 +0100 Received: from zaneeb.brainnet.i (IDENT:v3XdV8wvE1MsQ8J1nd37wR4d+cza8/wk@zaneeb.brainnet.i [127.0.0.1]) by zaneeb.brainnet.i (8.11.6/8.11.6) with ESMTP id h3TExG813380; Tue, 29 Apr 2003 15:59:16 +0100 Date: Tue, 29 Apr 2003 15:59:16 +0100 (BST) X-X-Sender: wez@zaneeb.brainnet.i To: Edin Kadribasic cc: Sascha Schumann , internals@lists.php.net In-Reply-To: <010601c30e5f$243a7a40$3600000a@intra.proventum.net> Message-ID: References: <010601c30e5f$243a7a40$3600000a@intra.proventum.net> MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="8323328-1768064484-1051628356=:7207" Subject: Re: [PHP-DEV] *= operator broken on Mac OS X and Windows [crit bug #23395] From: wez@thebrainroom.com (Wez Furlong) --8323328-1768064484-1051628356=:7207 Content-Type: TEXT/PLAIN; charset=US-ASCII This patch corrects the problem by not destroying the op1 value during multiplication. --Wez. On Tue, 29 Apr 2003, Edin Kadribasic wrote: > The following piece of code > > $i = 1; > $i *= 10; > echo $i; > > prints -2123890688 on Mac OS X, and 0 on Windows. > > The following commit is where breakage occured: > > http://cvs.php.net/diff.php/Zend/zend_operators.c?r1=1.129.2.1&r2=1.129.2.2&ty=u > > I suggest for this patch to be reverted since the commit message > reads "Speed up, simplify, use ZEND_SIGNED_MULTIPLY_LONG in > mul_operation" which doesn't sound like a bug fix that should be in > the stable branch. > > Edin > > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > > --8323328-1768064484-1051628356=:7207 Content-Type: TEXT/PLAIN; charset=US-ASCII; name="fix.diff" Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename="fix.diff" SW5kZXg6IFplbmQvemVuZF9tdWx0aXBseS5oDQo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09DQpSQ1MgZmlsZTogL3JlcG9zaXRvcnkvWmVuZC9BdHRpYy96ZW5k X211bHRpcGx5Lmgsdg0KcmV0cmlldmluZyByZXZpc2lvbiAxLjEuMi4zDQpk aWZmIC11IC1wIC1yMS4xLjIuMyB6ZW5kX211bHRpcGx5LmgNCi0tLSBaZW5k L3plbmRfbXVsdGlwbHkuaAkxNiBBcHIgMjAwMyAwNTozODo0MSAtMDAwMAkx LjEuMi4zDQorKysgWmVuZC96ZW5kX211bHRpcGx5LmgJMjkgQXByIDIwMDMg MTQ6NTg6MDggLTAwMDANCkBAIC0zMiw5ICszMiwxMCBAQA0KICNlbHNlDQog DQogI2RlZmluZSBaRU5EX1NJR05FRF9NVUxUSVBMWV9MT05HKGEsIGIsIGx2 YWwsIGR2YWwsIHVzZWR2YWwpIGRvIHsJXA0KLQkoZHZhbCkgPSAoZG91Ymxl KSAoYSkgKiAoZG91YmxlKSAoYik7CQkJCQkJCVwNCisJZG91YmxlIF9fdG1w X3ZhciA9IChkb3VibGUpIChhKSAqIChkb3VibGUpIChiKTsJCQkJCVwNCiAJ CQkJCQkJCQkJCQkJCQkJCVwNCiAJaWYgKChkdmFsKSA+PSBMT05HX01BWCB8 fCAoZHZhbCkgPD0gTE9OR19NSU4pIHsJCQkJCVwNCisJCShkdmFsKSA9IF9f dG1wX3ZhcjsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIFwNCiAJCSh1c2VkdmFsKSA9IDE7CQkJCQkJCQkJCQkJXA0KIAl9IGVs c2UgewkJCQkJCQkJCQkJCQkJXA0KIAkJKGx2YWwpID0gKGEpICogKGIpOwkJ CQkJCQkJCQkJXA0K --8323328-1768064484-1051628356=:7207--