Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:110579
MIME-Version: 1.0
References: <CAJvSBVPVHYOvd1VwEE1eqxvLr18AG3kc7S-nzs1KwjdtvmA2WA@mail.gmail.com>
In-Reply-To: <CAJvSBVPVHYOvd1VwEE1eqxvLr18AG3kc7S-nzs1KwjdtvmA2WA@mail.gmail.com>
Date: Tue, 16 Jun 2020 11:41:30 +0100
Message-ID: <CA+kxMuR7A+aQ+fWOaPX4pMyid90Phy7rx8NX3DCE4R2ak_eyTw@mail.gmail.com>
To: Peter Bowyer <phpmailinglists@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] SQLite3, PDO/SQLite and driver specific methods
From: Danack@basereality.com (Dan Ackroyd)

On Tue, 16 Jun 2020 at 11:32, Peter Bowyer <phpmailinglists@gmail.com> wrote:
>
> If it is, how can we change and improve the current situation?
>

Hi Peter,

I think what I wrote earlier is still a good approach:
https://externals.io/message/100773#100813

> Taking it to a better solution is that the method sqliteCreateFunction
> shouldn't exist on the PDO class, but instead on a PDOSqlite that
> extends PDO.
>
> class PDOSqlite extends PDO {
>      public function createFunction(...) {...}
> }
>
> class PDO {
>     public static function connect(string $dsn [, string $username [,
>         string $password [, array $options ]]]) {
>          if (connecting to SQLite DB) {
>            return new PDOSqlite(...);
>        }
>.       // return new PDO(...);
>    }
> }

Note, I haven't done the work to actually make sure that this plan is
actually feasible, so it's not guaranteed to be the correct approach.
But it still sounds sensible and would scale out to other custom
methods for other connection types, and avoid any magic.

If you (or anyone) have the time to work on this, that would be fantastic.

cheers
Dan
Ack