Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:110533
MIME-Version: 1.0
References: <BY5PR15MB3729227C6536FA3D0EBE2335929C0@BY5PR15MB3729.namprd15.prod.outlook.com>
In-Reply-To: <BY5PR15MB3729227C6536FA3D0EBE2335929C0@BY5PR15MB3729.namprd15.prod.outlook.com>
Date: Mon, 15 Jun 2020 12:18:26 -0600
Message-ID: <CAK70goPUhRRC_fppOJ1kuLXbeR5NDZC35uXuoSOSuhSrnU03kA@mail.gmail.com>
To: Daniel Rodrigues Lima <danielrodrigues-ti@hotmail.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] About the use of the terms master/slave and blacklist,
 proposal to replace.
From: cja987@gmail.com (Chuck Adams)

Oh man, not this again, not here.  Nothing intelligent ever comes out of th=
is.

Looks like most instances in the PHP source refer to mysql constants,
which means the ball would be in mysql's court.  Reality is you'd
still need the aliases that contain the offending word.

The other is in ext/standard/proc_open.c, referring to a "slave pty".
Seems pretty trivial to change.

But "trivial" is the operative word here.  Go join a protest and/or
call your congressperson if you want to actually do something
constructive.

Heck, it's not a big list.  How about nobody EVEN starts on the name
of the branch...

=E2=9C=94 ~/proj/php/php-src [master|=E2=9C=94]$ ag slave
ext/standard/tests/file/userstreams.phpt
17:to the game you stay a slave

ext/standard/proc_open.c
613:static int set_proc_descriptor_to_pty(descriptorspec_item *desc,
int *master_fd, int *slave_fd)
616: /* All FDs set to PTY in the child process will go to the slave
end of the same PTY.
620: * slave FDs. */
622: if (openpty(master_fd, slave_fd, NULL, NULL, NULL)) {
629: desc->childend   =3D dup(*slave_fd);
761: int ndesc, int nindex, int *pty_master_fd, int *pty_slave_fd) {
803: /* Set descriptor to slave end of PTY */
804: retval =3D set_proc_descriptor_to_pty(&descriptors[ndesc],
pty_master_fd, pty_slave_fd);
925: int pty_master_fd =3D -1, pty_slave_fd =3D -1;
998: &pty_master_fd, &pty_slave_fd) =3D=3D FAILURE) {
1220: if (pty_slave_fd !=3D -1) {
1221: close(pty_slave_fd);

ext/mysqlnd/mysqlnd_enum_n_def.h
599: STAT_COM_REGISTER_SLAVE,
664: COM_REGISTER_SLAVE,
692:#define MYSQLND_REFRESH_SLAVE 64 /* Reset master info and restart slave=
 */

ext/mysqlnd/mysqlnd_libmysql_compat.h
127:#define REFRESH_SLAVE MYSQLND_REFRESH_SLAVE

ext/mysqlnd/mysqlnd_wireprotocol.c
52:  "TABLE_DUMP", "CONNECT_OUT", "REGISTER_SLAVE",

ext/mysqlnd/mysqlnd_statistics.c
181: { MYSQLND_STR_W_LEN("com_register_slave") },

ext/gd/libgd/gd_png.c
365: /* 2.0.12: Slaven Rezic: palette images are not the only images

ext/mysqli/tests/mysqli_constants.phpt
97:        "MYSQLI_REFRESH_SLAVE" =3D> true,
200:            $expected_constants["MYSQLI_RPL_SLAVE"] =3D true;

ext/mysqli/tests/mysqli_get_client_stats.phpt
1250:  ["com_register_slave"]=3D>

ext/mysqli/mysqli.c
818: REGISTER_LONG_CONSTANT("MYSQLI_REFRESH_SLAVE",
REFRESH_SLAVE, CONST_CS | CONST_PERSISTENT);
=E2=9C=94 ~/proj/php/php-src [master|=E2=9C=94]$


--c

On Mon, Jun 15, 2020 at 9:43 AM Daniel Rodrigues Lima
<danielrodrigues-ti@hotmail.com> wrote:
>
> Hi internals,
>
> I think the time has come for the PHP internals to discuss the use of mas=
ter/slave and blacklist terminologies.
> As everyone can see, we are going through times of change in the world, s=
ee #blackLivesMatter for example.
> Therefore, I propose that we discuss the non-use of terms master/slave, b=
ecause the use of this can allude to the slavery and negative feelings abou=
t black people.
>
> Some projects that changed the terminology:
>
> * https://github.com/sebastianbergmann/phpunit/commit/8e9c76d33dab4095c90=
66072076f368193e4166d
> * https://go-review.googlesource.com/c/go/+/236857/
> * https://issues.apache.org/jira/browse/COUCHDB-2248
> * https://bugs.python.org/issue34605
>
> Greets,
>
> Daniel Rodrigues.
>
> geekcom@php.net<mailto:geekcom@php.net>
> https://twitter.com/geekcom2
> https://www.linkedin.com/in/danielrodrigueslima/
>