Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:110497 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 52144 invoked from network); 12 Jun 2020 11:20:30 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 12 Jun 2020 11:20:30 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 86B111804CE for ; Fri, 12 Jun 2020 03:04:52 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS15169 209.85.128.0/17 X-Spam-Virus: No X-Envelope-From: Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Fri, 12 Jun 2020 03:04:48 -0700 (PDT) Received: by mail-lj1-f177.google.com with SMTP id 9so10402699ljv.5 for ; Fri, 12 Jun 2020 03:04:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xr95mk3zummEx4Mdqki9smg2WJ9Kn2/WjIMjx7pR6+Y=; b=rKx14jN1eAfOCW2ufIO6Xo4x9H6Lt3ji8tyH3ih/YSLTwmghZy24J7AFqscBawzZGM jm9lN/88ZZcopaSMBKoYJbZ4mh/x9Y3/xl8laGRFhPCu0zFoIdIuJnUMSJmLdRCTPx77 t/z+DluyNKwxC/61CDzDUyfETIJ2z1PpsBqPGhPCXx6TcPhjMOvjiiuVeqJMl9zO9LXP d7f6jgK5FixPNSqsZSHZPzAALNhYZUIDCBhGYr35hFWYrn7fQna3m5OWcej8c4TdjEAj Eb9O45J3ZQSFFsyx530kYzX7DiJYyQ00g7PsOELDZvfWg1rstNQSO9LyhCnHa1JyUNuQ hh2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xr95mk3zummEx4Mdqki9smg2WJ9Kn2/WjIMjx7pR6+Y=; b=aNjs7fNzRaMmX8DCfftvk48o/2SCr0WlfWbWwGxEK3fq+ipGY64Y5pWOdWrxM7moUa 2/OqFnEVRG+xZiupgKD3T61qehQgn1Py84dNHBYnqONAp+LDjyzv0p48Fx0jZjwHfT7d ovlukPhtKZM+nMTNKwOju2rpOQVatSv7hIDw828xB/CndomG3ReFz3nT6/9Smwnrji7q 7guXqNz+gBsphVTxRWBsLEAw1Z9WhTqeu7Kz8ne7Hn/ebHUoPJ3Ago6L/CCSXgPmPrZ/ v4PENHfGZ1uqnC32ZZDg/eLLkfcYcGDXt1366m6DLO4RIr9EDoXTFu+g0mlAOJRZeuOO e0Gw== X-Gm-Message-State: AOAM533Gz18T57LSArTkF/SGx4IRhYJRDtfPlObpT8idJXNlJIv4vccB DlQKpupf8a5Nyk4JK0LCgcXGo7PBPMMCRkunBw== X-Google-Smtp-Source: ABdhPJxrPBCbxSRF6gJTH+I8Gp3g6rMLPCUbk8KEpCevwP5KYSYnjoM557E1krGvAqZKtS/D+AqRtojLMCuACzBtRgo= X-Received: by 2002:a2e:8705:: with SMTP id m5mr6214946lji.269.1591956287434; Fri, 12 Jun 2020 03:04:47 -0700 (PDT) MIME-Version: 1.0 References: <1914c612-99ef-5c12-0409-37424c071220@allenjb.me.uk> <800ec94b-608c-719f-9ca1-bb9d7cd8817e@gmail.com> In-Reply-To: <800ec94b-608c-719f-9ca1-bb9d7cd8817e@gmail.com> Date: Fri, 12 Jun 2020 12:04:36 +0200 Message-ID: To: Stanislav Malyshev Cc: Lynn , PHP internals , AllenJB , Rowan Tommins , Claude Pache Content-Type: multipart/alternative; boundary="00000000000002b77405a7e03532" Subject: Re: [PHP-DEV][RFC] Rename T_PAAMAYIM_NEKUDOTAYIM to T_DOUBLE_COLON From: guilliam.xavier@gmail.com (Guilliam Xavier) --00000000000002b77405a7e03532 Content-Type: text/plain; charset="UTF-8" > So please, let the parser tell me not only the line of the error, but also the colum. > Other information currently missing from the message - e.g. column > number, hints about unclosed blocks - is likely to be far more useful >> a) Character count (at line 456, character 23) > >> > >> b) Quote either the remainder or the parsed section on the line (MySQL > >> quotes the remainder, for example) > >> > >> c) Quote the whole line with an indicator where the error occurred. I'm > >> not sure what the best way to do this would be - generically this could > >> be encapsulated in several values: The line content, token start > >> character count, token length / end character count > >> > > > > I really like the combination of A + C. After using php for 13 years the > > If we could do the same as, for example, clang does: just display some > indication where the problem happened within the code, with the line > that caused it. Certainly not displaying internal token names, unless I > am debugging the parser they are useless. > Could this be discussed rather in the "Improvement to errors" thread? https://externals.io/message/110276 --00000000000002b77405a7e03532--