Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:110496
MIME-Version: 1.0
References: <CAFPFaMLZJV1BO_GdE7h73DVFaN7LiejeL1RJHL7QEoSa5B1H=A@mail.gmail.com>
 <EE81C9D2-84ED-4C6E-8A84-F7E5E5282507@gmail.com> <CAHWSxWSznXXtx_Duv0tJrU+sp-ytgPPZvxmat6ODwnr-FBjZJQ@mail.gmail.com>
 <CAESVnVq9HbEexZmbzPZZXU3nvTQiyJqtjdM9dO7wnO29G=xtvg@mail.gmail.com>
In-Reply-To: <CAESVnVq9HbEexZmbzPZZXU3nvTQiyJqtjdM9dO7wnO29G=xtvg@mail.gmail.com>
Date: Fri, 12 Jun 2020 11:30:34 +0200
Message-ID: <CAJmjfvUiO8HOB_HFohEV40o-RYd5iBYVw=MtdM+r4W1Gz7MbLQ@mail.gmail.com>
To: Sara Golemon <pollita@php.net>
Cc: Ryan Jentzsch <ryan.jentzsch@gmail.com>, Claude Pache <claude.pache@gmail.com>, 
	"G. P. B." <george.banyard@gmail.com>, PHP internals <internals@lists.php.net>, 
	Kalle Sommer Nielsen <kalle@php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV][RFC] Rename T_PAAMAYIM_NEKUDOTAYIM to T_DOUBLE_COLON
From: jakob@givoni.dk (Jakob Givoni)

On Thu, Jun 11, 2020 at 12:14 AM Sara Golemon <pollita@php.net> wrote:
>
> You know what shows up unambiguously in a google search? "Paamayim
> Nekudotayim".
> You know what ISN'T unambiguous in a google search? "Double Colon"

Straw man. The point being that you wouldn't have to Google "Double
Colon" because it is self explanatory.

> Token names shouldn't show up.  Everyone is agreeing with that statement.
> Universally.  Let's fix that problem rather than create new ones by not
> addressing the underlying issue.

Are you saying that this RFC is creating a new problem? If so, please elaborate.

>
> Once again I plead for logic and sanity. At least have the courage to put
> > it to a vote.
> >
> > Absolutely. Put it to a vote.  I've got my "no" all locked and loaded.

Why is this even an RFC? It's not a language change.
There seems to be consensus that those tokens should not be exposed in
error messages, so changing the name of one is not even a bugfix, it's
just an internal maintainability fix ;-)

If your position is "if it ain't broke, don't fix it", I think the
prudent thing to do would be to abstain from voting. If a change is
perceived as positive for at least one person and the rest are
indifferent, it's still a net positive change.

If your position is "error messages that you have to Google are better
than those you don't" then we should be seeing much more RFC proposing
to rename things like T_STRING to T_EMAFAI_ONAFAI_SAUKOFE etc. :-D

Best regards,
Jakob