Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:110446
MIME-Version: 1.0
References: <BYAPR05MB6535959E5CB99B9BE918E561DE880@BYAPR05MB6535.namprd05.prod.outlook.com>
 <CAEPJdumShcZMFSe_u0guVX2RuFf5X9FRp=i+-b62UUvaJiFipQ@mail.gmail.com>
In-Reply-To: <CAEPJdumShcZMFSe_u0guVX2RuFf5X9FRp=i+-b62UUvaJiFipQ@mail.gmail.com>
Date: Tue, 9 Jun 2020 14:07:00 +0200
Message-ID: <CANS-=pcaNV-n_8XGEhmaYWBy09kqO-iHTZizJ4CCeLXPme_8og@mail.gmail.com>
To: Benjamin Eberlei <kontakt@beberlei.de>
Cc: Theodore Brown <theodorejb@outlook.com>, Sara Golemon <pollita@php.net>, carusogabriel34@gmail.com, 
	internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000002e3bbd05a7a59211"
Subject: Re: [PHP-DEV] [RFC] Shorter attribute syntax
From: kjarli@gmail.com (Lynn)

--0000000000002e3bbd05a7a59211
Content-Type: text/plain; charset="UTF-8"

On Tue, Jun 9, 2020 at 1:55 PM Benjamin Eberlei <kontakt@beberlei.de> wrote:

> Larry's suggestion about #[Attr] makes an important argument about allowing
> to declare attributes in code in PHP 7 in a forward compatible way that has
> not been brought up before.
>
> /** @ORM\Entity */
> #[ORM\Entity]
> class User {}
>
> This code would work on PHP 7 and 8.
>
> The #[] syntax would have about equally low breaking potential as @@. It
> would be the same syntax as Rusts, and close to C++/C# syntax.
>

Hi,

The idea of making annotations forward compatible in php7 this way has a
big + from me. I honestly don't mind the syntax too much. How would
multiline notations work with this?

#[ORM\Entity(
    arg1,
    arg2
)]

This notation would obviously break in php7. Would it be possible (in this
case) to do something like the following example? This would have php7 not
care because they are comments, while php8 could filter the # out and make
it a valid annotation.

#[ORM\Entity(
#   arg1,
#   arg2
#)]

I'm also okay with having everything on a single line, just wanted to point
out this might cause issues.

Regards,
Lynn

--0000000000002e3bbd05a7a59211--