Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:110437
To: internals@lists.php.net
References: <BYAPR05MB6535959E5CB99B9BE918E561DE880@BYAPR05MB6535.namprd05.prod.outlook.com>
 <CALKiJKrwUA4Mo4HmHVL6ChaQSidpgS3jmc3fqdbZgnob4gk0zg@mail.gmail.com>
 <BYAPR05MB6535BC6C6D0353AE92B6486DDE890@BYAPR05MB6535.namprd05.prod.outlook.com>
 <a589a9bc-67e8-e427-53ef-30b53525c388@gmail.com>
 <BYAPR05MB6535D02144B77539BC92F5C3DE840@BYAPR05MB6535.namprd05.prod.outlook.com>
 <5ebecd58-9f39-72b9-369d-dbb60b80af36@gmail.com>
 <BYAPR05MB653545D79EC9CFE5D4B19D61DE850@BYAPR05MB6535.namprd05.prod.outlook.com>
 <17c4780c-b4c5-d726-3ee7-915b7762bb57@fischer.name>
Message-ID: <656c4575-19cf-deb7-aea5-e86d97737f13@gmail.com>
Date: Mon, 8 Jun 2020 22:29:43 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.9.0
MIME-Version: 1.0
In-Reply-To: <17c4780c-b4c5-d726-3ee7-915b7762bb57@fischer.name>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-GB
Subject: Re: [PHP-DEV] [RFC] Shorter attribute syntax
From: rowan.collins@gmail.com (Rowan Tommins)

Hi Markus,


On 08/06/2020 19:08, Markus Fischer wrote:
> Since we humans read source more often then we write, I can only 
> suggest to everyone to conduct their own "visual" testing first and 
> not just judge on technical merits => I think it makes sense to 
> consider both here, since we're already discussing a change here.


I was just thinking about how different fonts would affect this, and 
particularly those with ligatures - a lot of coding fonts already 
include ligatures for << and >> and some have something for #[ as well; 
I wonder how easy it would be to create a "nice" ligature for @@

In doing so, I found this site which lets you compare text in a long 
list of programming fonts, which is interesting to play with how the 
different syntaxes "feel": https://www.programmingfonts.org/

It doesn't have a save/share function, so here's a code sample of the 
main styles discussed so far for people to play with:


// Currently implemented
<<ManyToMany(Phonenumber::class)>>
<<JoinTable("users_phonenumbers")>>
<<JoinColumn("user_id", "id")>>
<<InverseJoinColumn("phonenumber_id", "id", JoinColumn::UNIQUE)>>
private $phonenumbers;

// Proposed grouping
<<
   ManyToMany(Phonenumber::class),
   JoinTable("users_phonenumbers"),
   JoinColumn("user_id", "id"),
   InverseJoinColumn("phonenumber_id", "id", JoinColumn::UNIQUE),
 >>
private $phonenumbers;

// Rejected alternative in original RFC
@:ManyToMany(Phonenumber::class)
@:JoinTable("users_phonenumbers")
@:JoinColumn("user_id", "id")
@:InverseJoinColumn("phonenumber_id", "id", JoinColumn::UNIQUE)
private $phonenumbers;

// Double-at proposal
@@ManyToMany(Phonenumber::class)
@@JoinTable("users_phonenumbers")
@@JoinColumn("user_id", "id")
@@InverseJoinColumn("phonenumber_id", "id", JoinColumn::UNIQUE)
private $phonenumbers;

// Rust-style
#[ManyToMany(Phonenumber::class)]
#[JoinTable("users_phonenumbers")]
#[JoinColumn("user_id", "id")]
#[InverseJoinColumn("phonenumber_id", "id", JoinColumn::UNIQUE)]
private $phonenumbers;

// Rust-style with grouping
#[
   ManyToMany(Phonenumber::class),
   JoinTable("users_phonenumbers"),
   JoinColumn("user_id", "id"),
   InverseJoinColumn("phonenumber_id", "id", JoinColumn::UNIQUE),
]
private $phonenumbers;


Regards,

-- 
Rowan Tommins (né Collins)
[IMSoP]