Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:110428
MIME-Version: 1.0
References: <CAJd4=YZd3Mh8sQjYxE-YfNim-CN1+j8oST2W+nykXDynC_KQiA@mail.gmail.com>
 <CADyq6sKn7ERUTmHfOSt6bOeWvFiS33ciaK7WZuLgktCs7AN3zg@mail.gmail.com>
 <CAJd4=YYt46c4tyuaRxgv6VTrerSZsNG-G4OUYEHPPrLOEYDSew@mail.gmail.com>
 <CADyq6sK8tJnV9igmeogcoGOHhVS=84R4V37KoDy15K-1xo49pg@mail.gmail.com>
 <CAJd4=YZ4ZeEb-PhFUnN_y2+XP8JS8P60KurtrHf1FWZDdRHF8w@mail.gmail.com> <CAJd4=YapHmvipX0sPpZgc=8kaTEeJk7OpR0H=Fn3di7jhbaWSA@mail.gmail.com>
In-Reply-To: <CAJd4=YapHmvipX0sPpZgc=8kaTEeJk7OpR0H=Fn3di7jhbaWSA@mail.gmail.com>
Date: Mon, 8 Jun 2020 18:06:26 +0200
Message-ID: <CADyq6sKG-e2n6Hqy9xLiEtkD+NNFarRWohmMtDXpOntE2v4v-Q@mail.gmail.com>
To: =?UTF-8?Q?Pedro_Magalh=C3=A3es?= <mail@pmmaga.net>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000b37aa105a794cbfc"
Subject: Re: [PHP-DEV] [RFC] [Discussion] Remove inappropriate inheritance
 signature checks on private methods
From: ocramius@gmail.com (Marco Pivetta)

--000000000000b37aa105a794cbfc
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hey Pedro,

On Mon, Jun 8, 2020 at 5:59 PM Pedro Magalh=C3=A3es <mail@pmmaga.net> wrote=
:

> On Wed, May 27, 2020 at 12:07 AM Pedro Magalh=C3=A3es <mail@pmmaga.net> w=
rote:
>
>> On Tue, May 26, 2020 at 3:46 PM Marco Pivetta <ocramius@gmail.com> wrote=
:
>>
>>> Considering that, as far as I know, only the constructor remains
>>> "special".
>>>
>>
>> Leaving the special case only for constructors instead of all magic
>> methods sounds better to me. Right now, that sounds like a winning
>> compromise for the RFC. It is still an exception to a rule, but one that
>> can be better justified.
>>
>> Thanks,
>> Pedro
>>
>
> I have updated both the implementation and the RFC to reflect this
> exception for constructors. If no further discussion comes up, I'll open
> the vote in a few days.
>
> Regards,
> Pedro
>

Looking good! Just some formatting issues around __construct (rendered as
_construct), but otherwise I would vote +1 for this!

Marco Pivetta

http://twitter.com/Ocramius

http://ocramius.github.com/

--000000000000b37aa105a794cbfc--