Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:110393
MIME-Version: 1.0
References: <CAGgaK7JhGLL-6mKF+q7GxTgNZ0uVsLg=-Wc0memQuWEatG_HQg@mail.gmail.com>
In-Reply-To: <CAGgaK7JhGLL-6mKF+q7GxTgNZ0uVsLg=-Wc0memQuWEatG_HQg@mail.gmail.com>
Date: Fri, 5 Jun 2020 19:03:51 +0200
Message-ID: <CAF+90c_U8PQCoqXbhY-Sd2M+_vHmRdd=e1=etFVOo4=d9b57Og@mail.gmail.com>
To: Max Semenik <maxsem.wiki@gmail.com>
Cc: Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000ce205905a7593f4a"
Subject: Re: [PHP-DEV] Refactoring run-tests.php
From: nikita.ppv@gmail.com (Nikita Popov)

--000000000000ce205905a7593f4a
Content-Type: text/plain; charset="UTF-8"

On Fri, Jun 5, 2020 at 5:42 PM Max Semenik <maxsem.wiki@gmail.com> wrote:

> I was thinking about making some improvements to our venerable test runner,
> however I wasn't feeling confident about improving the present code base.
> Instead, I decided to attempt to refactor it.
>
> Here's my work in progress:  https://github.com/MaxSem/run-tests
>
> It requires Composer only for development, and has a script to make a
> single-file distribution, functionally identical to what we presently have.
>
> When it comes to integration with php-src, it could be moved to a
> subdirectory there or be kept in a separate repository and be used to
> generate a new run-tests.php whenever needed.
>
> Is there interest in this, should I continue? Any suggestions?
>

Happy to accept run-tests refactorings in general (there is a lot of global
state to eradicate!), but please keep it single-file. We definitely need it
single-file for distribution purposes, and I don't particularly want to
have a "run-tests build system" for what I perceive to be little benefit.

I'm not sure why PHP developers in particular seem to be so hung up about
this issue, but: There really is no need to split every class into a
separate file. This is how we develop in non-PHP, non-Java languages
(C/C++/Rust/...) all the time.

Regards,
Nikita

--000000000000ce205905a7593f4a--