Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:110324
MIME-Version: 1.0
References: <CAEPJdum6xCwABjpor1YYvuosSB1dEb4xnCZEMABKsEEvNXvcQQ@mail.gmail.com>
 <BYAPR05MB65353FFCCE742728E4193F9DDE8D0@BYAPR05MB6535.namprd05.prod.outlook.com>
In-Reply-To: <BYAPR05MB65353FFCCE742728E4193F9DDE8D0@BYAPR05MB6535.namprd05.prod.outlook.com>
Date: Mon, 1 Jun 2020 11:03:38 +0100
Message-ID: <CALKiJKor+e9bRc0PDtq70=D72kC6T1cAfNUU_MKGsHpeuJ=h0g@mail.gmail.com>
To: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000062d55705a702e917"
Subject: Re: [PHP-DEV] [RFC] Amendments to Attributes
From: rowan.collins@gmail.com (Rowan Tommins)

--00000000000062d55705a702e917
Content-Type: text/plain; charset="UTF-8"

On Mon, 1 Jun 2020 at 00:48, Theodore Brown <theodorejb@outlook.com> wrote:

>
> Having a distinct token for attributes would entirely avoid the issues
> of having to modify multiple lines when adding/removing attributes, as
> well as confusion with shift operators and comma-separated attribute
> arguments. E.g. the RFC example would look like this instead:
>
> ```php
> @@Attr2("foo")
> @@Attr2("bar")
> public function test()
> {
> }
> ```
>


I'm not sure what you mean by "having a distinct token"; the cases where
there is any chance of confusion with bit-shifts are going to be very rare,
and aren't related to any of the other issues you're discussing. You make
some good points about not having comma-separated attributes, but they
don't require us to change the syntax, just not add that feature to it.

On a personal note, I find @@ a lot uglier than << and think a bracket-link
syntax looks clearer when writing multiple attributes on one line to avoid
long thin columns of code:

<<Attr2("foo")>> <<Attr2("bar")>>
public function test()
{
}

vs

@@Attr2("foo") @@Attr2("bar")
public function test()
{
}

Regards,
-- 
Rowan Tommins
[IMSoP]

--00000000000062d55705a702e917--