Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:110320
MIME-Version: 1.0
References: <CAP=4hCKgwc9_Q6NtVnHajc3HAsHATPvLH-MLAKSQP=m+xP2yEg@mail.gmail.com>
In-Reply-To: <CAP=4hCKgwc9_Q6NtVnHajc3HAsHATPvLH-MLAKSQP=m+xP2yEg@mail.gmail.com>
Date: Sun, 31 May 2020 15:56:47 +0200
Message-ID: <CAF+90c-S8xBwL04GgaS1dLQEEdeG4Kx2h7iYiJrstcEK22m9hg@mail.gmail.com>
To: Gabriel Caruso <carusogabriel34@gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000098605605a6f20d4a"
Subject: Re: [PHP-DEV] [VOTE] Ensure correct signatures of magic methods
From: nikita.ppv@gmail.com (Nikita Popov)

--00000000000098605605a6f20d4a
Content-Type: text/plain; charset="UTF-8"

On Fri, May 29, 2020 at 6:45 PM Gabriel Caruso <carusogabriel34@gmail.com>
wrote:

> Hello, internals!
>
> I have opened the voting for
> https://wiki.php.net/rfc/magic-methods-signature.
>
> The voting period ends on 2020-06-19 at 18h (CEST).
>

The RFC is a bit unclear on what is actually being proposed. It says

> This RFC proposes to add parameter and return types checks per the
following details.

and goes on to list (reasonable looking) magic method signatures, but does
not say how exactly those types are going to be checked. Is this going to
require exactly the same signature, or is this going to be in accordance
with variance rules? For example, are all of the following signatures valid
under this RFC? Only the first two? None of them?

    // Narrowed return type from ?array
    public function __debugInfo(): array {}

    // Narrowed return type from mixed
    public function __get(string $name): int {]

    // Widened argument type from string
    public function __get(string|array $name): mixed {}

Also, is omitting the return type still permitted, even though it would
nominally violate variance?

    public function __debugInfo() {}

Finally, if omitting the return type is permitted, will an implicit return
type be added, like we do for __toString()? Would the method automatically
become

    public function __debugInfo(): ?array {}

and report as such from reflection?

Nikita

--00000000000098605605a6f20d4a--