Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:110276
MIME-Version: 1.0
Date: Tue, 26 May 2020 09:56:10 -0300
Message-ID: <CAEsg9X0vyDufbnjt+-KgLfd5087H-DsUZfLV5rc7gyW+KXpDag@mail.gmail.com>
To: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000005f146205a68c9fe7"
Subject: Improvement to errors
From: david.proweb@gmail.com (David Rodrigues)

--0000000000005f146205a68c9fe7
Content-Type: text/plain; charset="UTF-8"

Hello!

I've been thinking that some errors in PHP are very difficult to
understand. Especially when we use two equal functions with different
arguments on the same line. The error does not make it clear where the
error is.

$strVariable = 'hello';
$nullVariable = null;
return strlen($strVariable) - strlen($nullVariable);

The second strlen() will causes an error: "strlen() expects parameter 1 to
be string, null given - line 107".

So I thought of two possible solutions:

1. Improve the error description, displaying parameters and information
that are easy to reuse (eg. variables).

- "strlen($nullVariable) expects parameter 1 to be string, null given -
line 107"

2. Indicate the offset from where the function was called, along with the
line (which already exists).

- "strlen() expects parameter 1 to be string, null given - line 107:30"

I believe that the second solution is the simplest to be implemented and
already solves the problem enough.


Atenciosamente,
David Rodrigues

--0000000000005f146205a68c9fe7--