Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:110273
MIME-Version: 1.0
References: <CAEPJdum6xCwABjpor1YYvuosSB1dEb4xnCZEMABKsEEvNXvcQQ@mail.gmail.com>
 <CAF+90c_QNBU-cc_3g7wrCFb8b_FbGR-hOFs2XOk1aJdTsXh=Ag@mail.gmail.com> <dc3901ba-4708-54ae-169a-46b2e8010f11@gmail.com>
In-Reply-To: <dc3901ba-4708-54ae-169a-46b2e8010f11@gmail.com>
Date: Mon, 25 May 2020 23:12:32 +0300
Message-ID: <CANeKSiTMR_aqE4eHH-7Et3pPk6yprF-NX13ujW9T8=1OaB4=Qg@mail.gmail.com>
To: Rowan Tommins <rowan.collins@gmail.com>
Cc: PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000000d84cc05a67e9aab"
Subject: Re: [PHP-DEV] [RFC] Amendments to Attributes
From: benas.molis.iml@gmail.com (Benas IML)

--0000000000000d84cc05a67e9aab
Content-Type: text/plain; charset="UTF-8"

That's a brilliant idea, completely agreed, Rowan!

On the other note, don't want to nitpick here but I believe that it would be
better to name the repeatable attribute simply as `<<Repeatable>>`. It would
match other languages (such as Java) and the naming wouldn't be that
verbose.

Also IMO, I think for consistency we should either use only parameters e. g.
`<<Attribute(Attribute::TARGET_ALL, Attribute::REPEATABLE)>>` or separate
attributes for both target validation and repeatability e. g.
`<<Target(Target::ALL)>>`  and `<<Repeatable>>`.

Best regards,
Benas Seliuginas

--0000000000000d84cc05a67e9aab--