Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:110265
Content-Type: text/plain;
	charset=us-ascii
In-Reply-To: <CAF+90c_QNBU-cc_3g7wrCFb8b_FbGR-hOFs2XOk1aJdTsXh=Ag@mail.gmail.com>
Date: Sat, 23 May 2020 03:34:44 +0200
Cc: PHP Internals <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID:
 <VI1PR02MB47035C04277DF2ACA7CA5540E2B50@VI1PR02MB4703.eurprd02.prod.outlook.com>
References: <CAEPJdum6xCwABjpor1YYvuosSB1dEb4xnCZEMABKsEEvNXvcQQ@mail.gmail.com>
 <CAF+90c_QNBU-cc_3g7wrCFb8b_FbGR-hOFs2XOk1aJdTsXh=Ag@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>,
 Benjamin Eberlei <kontakt@beberlei.de>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [IPv6:2001:7e8:cb71:d400:599:ffb5:fb10:685b] (2001:7e8:cb71:d400:599:ffb5:fb10:685b) by PR3P189CA0011.EURP189.PROD.OUTLOOK.COM (2603:10a6:102:52::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3021.25 via Frontend Transport; Sat, 23 May 2020 01:34:45 +0000
X-Mailer: Apple Mail (2.3445.104.11)
X-Microsoft-Original-Message-ID:
 <097234BB-4849-47BD-94A6-901F3157654D@hotmail.com>
X-TMN: [fjV5zPekUktNAWG1mVkp2twLPlvTZmq0RPLaZPIC+HAA4rYIQqGJz1L1K2RlcBZj]
X-MS-PublicTrafficType: Email
X-IncomingHeaderCount: 50
X-EOPAttributedMessage: 0
X-MS-Office365-Filtering-Correlation-Id: 6cecb2c5-3818-4caf-0eca-08d7feb9799b
X-MS-TrafficTypeDiagnostic: DB8EUR06HT003:
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	PYrPJdviUQtpl7MUJG046G+S4rdUAFRDqaw8A3eyIXIpeXi5eF+0bo6yyaUZnIA/+D33cFd8/OkmYXHwIrcpRAyNAsMD3Z01Kjw7W1QQBczA00TT/3yTtu1b+UA33t8Cv1WBodrqrG1qNWoEgwuHmXs6cPMG8Qmlj8OQ7eQ9ZssoFS7LFPxjFg8/6T6kbnyVQbVVsU0md/lrx9nYbYHpdQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:0;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR02MB4703.eurprd02.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:;DIR:OUT;SFP:1901;
X-MS-Exchange-AntiSpam-MessageData:
	ZYukIfy0XmeU4pEwpCfBAn4iD7idcIbEg3dC096PuhxXROvAU9HiC5IJjCm1R30GAKHHujPEOGPe2WefoI35mZxs9kwumsnjeSbsl7UR8L87pM1fBL9KiKtGsFnBE3mBvV7Yek1Hkgq8YqTZHJqWxh023AoaqQ0P+f0eeFcjPgVdt05E6wOsTuICskO1lV4/YRHtWYuBRGP8MclONeQcPw==
X-OriginatorOrg: hotmail.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6cecb2c5-3818-4caf-0eca-08d7feb9799b
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2020 01:34:47.5738
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-FromEntityHeader: Internet
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8EUR06HT003
Subject: Re: [PHP-DEV] [RFC] Amendments to Attributes
From: bobwei9@hotmail.com (Bob Weinand)

> Am 22.05.2020 um 13:08 schrieb Nikita Popov <nikita.ppv@gmail.com>:
>=20
> On Wed, May 20, 2020 at 7:08 PM Benjamin Eberlei <kontakt@beberlei.de>
> wrote:
>=20
>> 2. Rename PhpAttribute to Attribute in global namespace (independent of =
the
>> namespace RFC)
>=20
> As was mentioned in one of the previous discussions, we expect that PHP i=
s
> going to ship more language-provided attributes in the future. With this
> proposal we have the "Attribute" attribute, but I expect we'll at least
> have "Deprecated" as well, and probably also something along the lines of
> "Jit" or "NoJit". While I'm happy with "Attribute" living in the global
> namespace, I don't really think we'd want to introduce "Jit" as a class i=
n
> the global namespace. The name is simply to generic and does not indicate
> that this is part of the attribute system. We'd be forced to go with thin=
gs
> like DeprecatedAttribute or JitAttribute, which seems rather non-optimal =
to
> me, as we're just reinventing namespaces to avoid using them...
>=20
> As such, I would suggest to introduce a common namespace for all attribut=
es
> provided by PHP. This means we'd have Attributes\Attribute,
> Attributes\Deprecated, Attributes\Jit, Attributes\NoJit etc. (I'm also ok=
ay
> with the PHP\Attributes\Deprecated variant, but that's a separate questio=
n).
>=20
> Nikita

At that point, don't we just want to be able to generically mark all attrib=
ute classes visible as being an Attribute?

Also the classical examples like <<ORM\Entity("...")>> do not tell you anyh=
ow that they're Attributes, if the class is accessed outside of attribute c=
ontext. And I guess, with the logic you proposed, it will likely be named "=
ORM\Attribute\Entity" making it even longer.

I think it would be good to be able to later on just write <<Deprecated>>, =
<<JIT>> etc. without further imports, as they seem to be quite basic functi=
onality. I think it should remain possible to write simple code without muc=
h namespace awareness.

Perhaps we should actually name attribute classes including their << and >>=
. Thus "class <<JIT>> {}" (attribute decl), "new <<JIT>>()" (custom instant=
iation), "$attribute instanceof <<JIT>>". (and, for a namespaced attribute =
"$attribute instanceof MyNamespace\<<MyAttrr>>")
The engine could quite easily support that, it's just a little parser work.

That way the whole discussion as to where to put attributes in the namespac=
e hierarchy would be quite moot, for PHP itself as well as userland.

Bob

P.s.: As a caveat, on parameter types, if we expect a value being of an att=
ribute class, we'd need to require a qualified name containing at least one=
 backslash or import-alias there. But that's acceptable I think, it will ju=
st happen within some internal attribute processing code.=