Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:110247
MIME-Version: 1.0
References: <CAEPJdum6xCwABjpor1YYvuosSB1dEb4xnCZEMABKsEEvNXvcQQ@mail.gmail.com>
 <CAF+90c_QNBU-cc_3g7wrCFb8b_FbGR-hOFs2XOk1aJdTsXh=Ag@mail.gmail.com>
 <CAJvSBVNcECz0B2fx+LBXW34rnw3bYcqcpFn1LfjNBkiV9+b7bg@mail.gmail.com> <CANeKSiQAR5DqmasExBzqgfGwSwHk-mx97Q0xBZivJARmgNXiRQ@mail.gmail.com>
In-Reply-To: <CANeKSiQAR5DqmasExBzqgfGwSwHk-mx97Q0xBZivJARmgNXiRQ@mail.gmail.com>
Date: Fri, 22 May 2020 17:28:13 +0200
Message-ID: <CAF+90c_yf+Fs4fQwYQYbEi70y5N_JQe564QTYV6vFpiJ_5-Yhw@mail.gmail.com>
To: Benas IML <benas.molis.iml@gmail.com>
Cc: Peter Bowyer <phpmailinglists@gmail.com>, Benjamin Eberlei <kontakt@beberlei.de>, 
	PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000f9001605a63e4782"
Subject: Re: [PHP-DEV] [RFC] Amendments to Attributes
From: nikita.ppv@gmail.com (Nikita Popov)

--000000000000f9001605a63e4782
Content-Type: text/plain; charset="UTF-8"

On Fri, May 22, 2020 at 2:19 PM Benas IML <benas.molis.iml@gmail.com> wrote:

> Agreed.
>
> I don't think we should pollute any other than the `PHP\` namespace. If
> that RFC doesn't pass though, we should keep the `Attribute` class in the
> global namespace.
>
> Global namespace is already reserved for PHP and so, BC breaks aren't that
> severe whereas `Attributes\` namespace isn't reserved therefore BC breaks
> would be "unexpected".
>
> Best regards,
> Benas Seliuginas
>

I mean, realistically speaking, BC breaks with Attributes\Attribute are a
lot less likely than with just Attribute, regardless of what we reserve or
don't. Some pragmatism, please.

I don't particularly care what namespace the attribute classes are under,
just that they should have a common namespace, because there's going to be
many of them, presumably. If it was just a matter of the Attribute class,
I'd definitely say this belongs in the global namespace, but that's not
what we're dealing with at this point.

Nikita

--000000000000f9001605a63e4782--