Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:110225
MIME-Version: 1.0
References: <CAEPJdum6xCwABjpor1YYvuosSB1dEb4xnCZEMABKsEEvNXvcQQ@mail.gmail.com>
 <F625940B-E5D7-40B1-9F6A-E2546757CC26@benramsey.com>
In-Reply-To: <F625940B-E5D7-40B1-9F6A-E2546757CC26@benramsey.com>
Date: Thu, 21 May 2020 00:13:18 +0200
Message-ID: <CAEPJdu=mMWKqVFABnK9OLuM7AhjR1nw-EqpvhUHGeZebGVouuA@mail.gmail.com>
To: Ben Ramsey <ben@benramsey.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000b8283405a61bb4ad"
Subject: Re: [PHP-DEV] [RFC] Amendments to Attributes
From: kontakt@beberlei.de (Benjamin Eberlei)

--000000000000b8283405a61bb4ad
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, May 20, 2020 at 7:53 PM Ben Ramsey <ben@benramsey.com> wrote:

> > On May 20, 2020, at 12:07, Benjamin Eberlei <kontakt@beberlei.de> wrote=
:
> >
> > 2. Rename PhpAttribute to Attribute in global namespace (independent of
> the
> > namespace RFC)
>
>
> I suggested in a previous thread that we consider renaming `PhpAttribute`
> to `UserlandAttribute`, since this is the intent of the attribute, and it
> helps distinguish it from `CompilerAttribute`.
>
> I noticed that the compiler attribute is actually named
> `PhpCompilerAttribute`, so unless we change its name to
> `CompilerAttribute`, I don=E2=80=99t think it makes sense to change `PhpA=
ttribute`
> to `Attribute`. Perhaps we change it to `PhpUserlandAttribute`, for clari=
ty?
>

Ah that's a good point that still needs to be clarified. We realized that
PhpAttribute and PhpCompilerAttribute should be merged, because the
difference doesn't make a difference to userland code and it complicates
things. For example enforcing that PhpCompilerAttribute is just on internal
classes would not work for generated stub code in Phan/Psalm and so on that
"describe" internal code by imitating it in userland. This would not be
allowed by the current implementation and lead to a compiler error, lets
say if we imitated Deprecated for documentation purposes:

<?php

<<PhpCompilerAttribute>>
class Deprecated {}

This file could not be compiled by current implementation as an error would
prevent Userland Deprecated class from using PhpCompilerAttribute.

>
> Cheers,
> Ben
>

--000000000000b8283405a61bb4ad--