Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:110213
MIME-Version: 1.0
References: <95831d80-baa0-a57c-e83a-bc34ae62ecf5@lear.ch> <c1b1242e-fdd8-adce-f204-7f5096b5c561@lear.ch>
 <CA+kxMuRfnj+QSUi=qhEc8GfS1BUizRkQh8wUjf-AQfFytUcwBQ@mail.gmail.com> <688cc886-394d-b245-d001-c5aefa332882@lear.ch>
In-Reply-To: <688cc886-394d-b245-d001-c5aefa332882@lear.ch>
Date: Tue, 19 May 2020 12:29:34 +0200
Message-ID: <CAFPFaMKtt1c5KjC=sJ5wE_-hDEysobSAocz3zr_3HunRvu0kvA@mail.gmail.com>
To: Eliot Lear <lear@lear.ch>
Cc: Dan Ackroyd <Danack@basereality.com>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000001fe92805a5fdc26d"
Subject: Re: [PHP-DEV] [RFC] Add CMS Support
From: george.banyard@gmail.com ("G. P. B.")

--0000000000001fe92805a5fdc26d
Content-Type: text/plain; charset="UTF-8"

On Tue, 19 May 2020 at 11:44, Eliot Lear <lear@lear.ch> wrote:

> Dan, thanks.  Please see below.
>
> On 18.05.20 13:49, Dan Ackroyd wrote:
> >> Returns TRUE on success and FALSE on failure.
> > Have you considered using an exception for failures?
> >
> > First, having a cryptographic function fail is bad enough that it
> > needs to break control flow, aka it would be easy to forget to check
> > for false. If the $outfile already existed before the call, and the
> > error condition wasn't checked, that could lead to Bad things.
> >
> > Second, I imagine there are multiple possible reasons why a crypto
> > function could fail. If the error is just 'false', then there would be
> > no way of figuring out what the problem is. More details could be
> > provided in the message of an exception ("can't open file for
> > writing", "signkey wrong format" etc) which would avoid a significant
> > amount of frustration.
>
> On your second point, the designers of OpenSSL and the earlier work on
> the PHP interface agree with you, as do I.  That is why there is indeed
> an interface to return multiple errors that is already defined
> (openssl_error_string) that can be called repeatedly.  This is similar
> to other OpenSSL interfaces.
>
> On your first point, I might academically want to explore it, but then
> we should do so for the entire openssl interface.
>
> Eliot
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>

I did start some work in this direction in:
https://github.com/php/php-src/pull/5111
But I'm not super familiar with OpenSSL myself, any review/help would be
appreciated (I do need to rebase it).

Best regards

George P. Banyard

--0000000000001fe92805a5fdc26d--