Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:110207
Return-Path: <levi.morrison@datadoghq.com>
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 76313 invoked from network); 18 May 2020 23:32:57 -0000
Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5)
  by pb1.pair.com with SMTP; 18 May 2020 23:32:57 -0000
Received: from php-smtp4.php.net (localhost [127.0.0.1])
	by php-smtp4.php.net (Postfix) with ESMTP id 248241804C3
	for <internals@lists.php.net>; Mon, 18 May 2020 15:11:15 -0700 (PDT)
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net
X-Spam-Level: 
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
	RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=no
	autolearn_force=no version=3.4.2
X-Spam-ASN: AS15169 209.85.128.0/17
X-Spam-Virus: No
X-Envelope-From: <levi.morrison@datadoghq.com>
Received: from mail-io1-f54.google.com (mail-io1-f54.google.com [209.85.166.54])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256)
	(No client certificate requested)
	by php-smtp4.php.net (Postfix) with ESMTPS
	for <internals@lists.php.net>; Mon, 18 May 2020 15:11:14 -0700 (PDT)
Received: by mail-io1-f54.google.com with SMTP id d7so12424500ioq.5
        for <internals@lists.php.net>; Mon, 18 May 2020 15:11:14 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=datadoghq.com; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=8ytVwOgNgPVMPin4XiaMFNF5TiqpnGoIHaryjLZZ1vQ=;
        b=Ui031cXeHR86F/d0u4GnpzH8wR8EQBarqDTA2gp3i+SRq5bWpziQ2rCe+tzpmmIkrT
         FV5OHm+VgZlXovlg8AUvW2ACYYTR7OhjnmyYPPvjaPjEFRkSIAs28tKqyUaWe4zUHON6
         Pe1sf+iLVfWKktZ18OGsMYKVwbPJ8jLA7NMJ4=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=8ytVwOgNgPVMPin4XiaMFNF5TiqpnGoIHaryjLZZ1vQ=;
        b=YwQiScE7zPvPIGtsQfEEyx3DgoQ/tbmKZ6+sYtw1gEW4E1YvDdtkeyim8ST5zLTISm
         JsKMNqbFJ07tgzXZ+PgbkYVj5oLhVlgksAvrExtFK3UCwhDSX7bCoRSfJiHZNDa9u9p1
         KjbVCD0PCERj5Em0/mWNIKgzDtCLFdERo3KELjTrNW1qcxzi4YnCQ0u+uNv3vNygicCa
         J+5oCs2KARCubEyZRU4D4iAi6BuyKHxowt2SV/99Bjot1YRr0kpyF4y9Tk4iT0TcRXay
         kNm/tpSPSCwgms6awMaZl/CJVohhlkQGE6rVljOeAgFY/YCfgtmnxWaaciOs0rE87J4x
         K4yQ==
X-Gm-Message-State: AOAM532XTOeVE65RO36rlvOYR4xtQBREb7fSAOeBO8mVmlXWFjFNBsFf
	k2s1208tgTfUTLPLJ7IZSFogvspZjxktobsUE4WE6wQk9LU=
X-Google-Smtp-Source: ABdhPJyo4/hdibCK3nmb4fTDVnrx63yltLGE9tED1MxP62zwrV+5CFHAaokVDWwAVceB5QIBkU1o3U0xKxOUfQ3fKnk=
X-Received: by 2002:a05:6638:a47:: with SMTP id 7mr17449893jap.12.1589839869942;
 Mon, 18 May 2020 15:11:09 -0700 (PDT)
MIME-Version: 1.0
References: <CAJmjfvU1z2C6r0XCnwZsuDFMy9LBdAaH-Uw8dQJgtAGuOe7H=g@mail.gmail.com>
 <CA+kxMuTCpUo4TKuC=cdTdv1p7AAc9-vdAQUq9vrf02+0J9aZRg@mail.gmail.com>
In-Reply-To: <CA+kxMuTCpUo4TKuC=cdTdv1p7AAc9-vdAQUq9vrf02+0J9aZRg@mail.gmail.com>
Reply-To: Levi Morrison <levi.morrison@datadoghq.com>
Date: Mon, 18 May 2020 16:10:59 -0600
Message-ID: <CAAKU0unAn5uAn62rbx=u2o2WA_CmLR0Waxzj=TmLXVXqkJLx7g@mail.gmail.com>
To: Dan Ackroyd <Danack@basereality.com>
Cc: Jakob Givoni <jakob@givoni.dk>, php internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] SPL development interest
From: internals@lists.php.net ("Levi Morrison via internals")

In my opinion, another key takeaway: inheritance as a code reuse
mechanism can really bite you. SplStack extends SplDoublyLinkedList
and this exposes a bunch of methods on a stack that don't make any
sense. It also means there are constraints on how well you can
optimize the stack, because you have these methods that don't make
sense on a stack that you _must_ support because some poor bloke
somewhere actually used them (may God have mercy on them).